Re: [orbit-dev] Please try latest I-build ... should we have "Eclipse-So

[David M Williams <david_williams@xxxxxxxxxx>]

One thing I've noticed with this latest
I-build, is that the Orbit bundles now contain Eclipse-SourceReference
directives. 

I have opened this bug to discuss: 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=338447

Is this a good thing? Or bad thing?
It doesn't seem like the source so imported is really valid ... the 'source-bundle'
directory is pulled in as a subdirectory of the main bundle (as would be
expected) but that source doesn't "compile" correctly (opening
one of those .java files shows lots of errors .. invalid package name,
etc.) 

So, the question I have, is what is
desired here? My guess is we should remove the 
generateSourceReferences=true
property and not generate Eclipse-SourceReferences,
because importing such a project as is will be confusing to all but Orbit
committers, I'd guess.  
But, maybe I'm seeing something wrong?
I basically only looked at one case, org.apache.oro. (The others I tried,
did not actually have a 'source-bundle' subdirectory. 

Please read and comment in the bugzilla
if you have an opinion. 

Thanks,







From:      
 David M Williams/Raleigh/IBM@IBMUS
To:      
 Orbit Developer discussion
<orbit-dev@xxxxxxxxxxx>
Date:      
 02/28/2011 02:45 AM
Subject:    
   [orbit-dev]
Please try latest I-build ...
Sent by:    
   orbit-dev-bounces@xxxxxxxxxxx

---

http://download.eclipse.org/tools/orbit/downloads/drops/I20110228060625/

This weekend, I've changed the build to no longer produce the "bundles"
directory as we have for the past 5 years. Besides no longer wasting this
space, it makes a few other differences, the most significant is the "get
http format" maps. They used to point to ../bundles jars and zips,
and now just point to .../repository/plugins jars. But, the ones that should
be unzipped when installed, are still marked "unpack=true" and
according to the discussion in bug 334488 [1] this should still work fine
with PDE build, for those that still use the old "get http format"
maps. But, that's my request to "please try" ... if anyone still
uses (or know any projects that still use) these "get http format"
maps, please have them try out the latest I-build, before we declare an
S-build on Friday, just in case there is some unanticipated effect. I did
try a little test build in our webtools project build, but we don't normally
use those "get http" map files (we use the p2 format, normally)
so not sure our build is the best test. This change also changes what the
individual links on download page table point to [2], but that's more of
an individual developer-user workflow change, nothing related to production,
and hopefully those individual links are rarely used. There should be no
other changes or implications.  Let us know if you notice anything
amiss. 

Thanks, 

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=334488
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=334487
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev