[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[orbit-dev] More on prebuilt bundles ...
|
FWIW, I've updated one of our wiki pages
with "lessons learned" going through the issues with pre-built
bundles. You can see if I missed anything
http://wiki.eclipse.org/Orbit/Adding_Bundles_to_Orbit#Adding_a_library_that_is_already_a_bundle
Thanks for pushing the limits Lazar
and reminding us not all things are documented very well.
From:
David M Williams/Raleigh/IBM@IBMUS
To:
Orbit Developer discussion
<orbit-dev@xxxxxxxxxxx>
Date:
01/17/2011 12:47 PM
Subject:
Re: [orbit-dev]
More on about.html file for felix.gogo prebuilt ...
Sent by:
orbit-dev-bounces@xxxxxxxxxxx
I think ordinarily, all projects (with
class files) should be "java projects" simply so they have a
.classpath file, which can "export" (expose) the classes to other
projects in the work bench. This is required for the project to work correctly
if loaded into the workspace and used by other projects ... as opposed
to simply being part of the IDE or runtime target. That's my understanding.
From: "Kirchev,
Lazar" <l.kirchev@xxxxxxx>
To: Orbit
Developer discussion <orbit-dev@xxxxxxxxxxx>
Date: 01/17/2011
10:07 AM
Subject: Re:
[orbit-dev] More on about.html file for felix.gogo prebuilt ...
Sent by: orbit-dev-bounces@xxxxxxxxxxx
Now I am ready with the discussed fixes – I unpacked the bundle content
in the project, added about.html, modified the MANIFEST to use four part
version and localization, added localization file. Now I have one more
question before committing this to the felix gogo project in the repository:
do I actually need the project to be a Java project? Other similar projects,
which pack binaries, are Java projects, but they provide also source for
the classes. I suppose that is why they are Java projects and for the case
with gogo this nature is not necessary. Or probably I miss something?
From: orbit-dev-bounces@xxxxxxxxxxx [mailto:orbit-dev-bounces@xxxxxxxxxxx]
On Behalf Of David M Williams
Sent: Friday, January 14, 2011 3:31 PM
To: Orbit Developer discussion
Subject: Re: [orbit-dev] More on about.html file for felix.gogo prebuilt
...
> Sorry for the naive question: it seems to me that gogo would be fine
> packaged just like a "normal" library: unzip it, commit
the bytecode
> and let orbit package the OSGi bundle.
> Orbit will sign the bundle and add the about.html file and other IP
> related files.
> It will also slightly modify the MANIFEST.MF
>
> Those types of modifications are accepted without re-filing a CQ.
>
All true.
> If I understood correctly the case of pre-built bundles like icu it
> is because they have already been signed and IBM requires to keep
> that signature.
>
Well ... that'd be a good story ... but, it is not literally true. I suspect
that was part of the original idea, but currently ICU is not signed or
anything, and if we had to, we could repackage it with no loss of information.
As it is, I think "prebuilt" bundles were originally seen as
the ideal ... as other projects all over the universe began to adopt OSGi
... but it never materialized quite as expected. And, as we've seen, even
when they do, there's some special, Eclipse specific requirements that
are not necessarily met. But when it is, we are ready! :)
> Would not it be simpler if we were to re-package gogo and just keep
> its bytecode?
Yes, I think so.
And ....
1) I'd like to be sure we get a "good build" today, so we have
an I-build to promote later in the day. So, if felix.gogo can not be fixed
soon (by this afternoon) I'll temporarily remove it from feature.xml, so
we can get a clean build.
2) I broke the build script overnight so the download page (and exact contents
of download site) was not completely finished. I think I have it fixed
now. Currently re-building. Apologies.
From: Hugues
Malphettes <hmalphettes@xxxxxxxxxxx>
To: Orbit Developer
discussion <orbit-dev@xxxxxxxxxxx>
Date: 01/14/2011
03:10 AM
Subject: Re:
[orbit-dev] More on abouthtml file for felix.gogo prebuilt ...
Sent by: orbit-dev-bounces@xxxxxxxxxxx
Sorry for the naive question: it seems to me that gogo would be fine packaged
just like a "normal" library: unzip it, commit the bytecode and
let orbit package the OSGi bundle.
Orbit will sign the bundle and add the about.html file and other IP related
files.
It will also slightly modify the MANIFEST.MF
Those types of modifications are accepted without re-filing a CQ.
If I understood correctly the case of pre-built bundles like icu it is
because they have already been signed and IBM requires to keep that signature.
Would not it be simpler if we were to re-package gogo and just keep its
bytecode?
Cheers,
Hugues
2011/1/14 David M Williams <david_williams@xxxxxxxxxx>
> I requested to use the binaries?
No, that's no problem. We still use the precompiled class files ... we
just explode them, then put them back together ... so we still count that
as 'binary'.
(Of course, its a nice idea to also ask/specify "source" on CQ's
... but, sometimes is not done and is not a requirement ... and that's
a whole other dimension anyway ... you can have a pre-built source bundle
too ... as icu does.)
I do not know of any alternative other than to blow it up and put in your
own about.html file, 4th version field, localization files ...
HTH
From: "Kirchev,
Lazar" <l.kirchev@xxxxxxx>
To: Orbit Developer
discussion <orbit-dev@xxxxxxxxxxx>
Date: 01/14/2011
02:12 AM
Subject: Re:
[orbit-dev] More on abouthtml file for felix.gogo prebuilt ...
Sent by: orbit-dev-bounces@xxxxxxxxxxx
I added an ip_log file for the gogo runtime project. The about.html will
be a problem. I checked the other three pre-built bundles and all of them
have about.html files. But some of them (namely com.jcraft.jsch) have 3
part version number. However, if we tweak the bundle for the about.html,
the version also may be changed. If there is no other option, I will submit
the code in the project, along with an about.html and enhanced version
number.
Will it be a problem that when I made the original CQ request for using
Gogo bundles (CQ 4561, followed by CQ 4690 for including in orbit), I requested
to use the binaries?
From: orbit-dev-bounces@xxxxxxxxxxx
[mailto:orbit-dev-bounces@xxxxxxxxxxx]
On Behalf Of David M Williams
Sent: Thursday, January 13, 2011 10:15 PM
To: Orbit Developer discussion
Subject: [orbit-dev] More on abouthtml file for felix.gogo prebuilt
...
I see the missing about.html file as kind of a sticky issue. We are required
to have one per Eclispe Foundation IP requirements ... but the original,
pre-built bundle does not have one.
So, I'd say this means we can not treat this as pre-built and must tweak
it to add our Eclipse-required about.html file.
Unless others know otherwise? I assume ICU and other pre-builts just happened
to have an acceptable about.html file?
That's kind of unfortunate, that there's no way to "inject" one
... but ... I also noticed this bundle only has a 3 part version number.
It should have 4. (with .qualifier added) according to good practices,
or at least our Sim. Release requirements. So, that'd be another
advantage to tweaking it.
Of course, if someone wanted to work with the original felix.gogo project
to get a new/improved version, new CQ, etc. that'd be fine (ideal even)
but I do not know if that is realistic. The 4 part version number
seems like a good idea for any good OSGi bundle ... but, the about.html
might be a pretty Eclipse specific convention. I also just noticed it has
no "localization" files. Not sure there'd be much to translate,
and we could maybe live without that if that was the only thing ... but,
we definitely need the about.html file, and best to have some qualifier.
Anyone have a better idea (better than not using it "pre-built",
and tweaking it into compliance, that is)?
From: DJ Houghton
<DJ_Houghton@xxxxxxxxxx>
To: Orbit Developer
discussion <orbit-dev@xxxxxxxxxxx>
Date: 01/13/2011
01:47 PM
Subject: Re:
[orbit-dev] [ORBIT-BUILD: orbit-I] orbit-I Build Failed
Sent by: orbit-dev-bounces@xxxxxxxxxxx
According to [1], the org.apache.felix.gogo.runtime bundle is missing an
about.html file.
It is also missing an ip_log file [2] as well.
[1] http://download.eclipse.org/tools/orbit/committers/drops/I20110113160323/
[2] http://wiki.eclipse.org/Orbit_Bundle_Checklist#Update_the_IP_Log
orbitBuilder
---01/13/2011 12:32:50 PM---View results here -> http://build.eclipse.org:9777/dashboard/tab/build/detail/orbit-I?log=log201101
View results here -> http://build.eclipse.org:9777/dashboard/tab/build/detail/orbit-I?log=log20110113160323
| BUILD FAILED
|
| Ant Error Message:
| /shared/orbit/org.eclipse.orbit.releng.control/cc_project_build.xml:86:
The following error occurred while executing this line: /shared/orbit/org.eclipse.orbit.releng.control/cc_project_build.xml:112:
Tests failed. See test log.
|
| Date of build:
| 2011-01-13T16:03:23
|
| Time to build:
| 88 minutes 12 seconds
|
| Last changed:
| 2011-01-13T16:01:23
|
| Last log entry:
| Change entry for gogo bundle
to explicitly list the field names. |
| Errors/Warnings:
(32)
|
| Test org.eclipse.orbit.releng.tests.TestLayout
FAILED
|
checkout.builder.clean: true
retieved new version of build.cfg
Version tag for org.eclipse.orbit/org.eclipse.orbit.releng.builder is:
v201101121852
retieved new version of org.eclipse.orbit/org.eclipse.orbit.releng.builder
cctimestamp: 20110113160323
datetime: 201101131623
timestamp: 20110113160323
buildfile: /shared/orbit/projectBuilders/orbit-I/org.eclipse.orbit/org.eclipse.orbit.releng.builder/distribution/orbit.build/build.xml
resolution.devMode: true
cvsaccess: pserver:anonymous
buildDirectory: /shared/orbit/projects/orbit-I/workdir
chmod for /shared/orbit/projects/orbit-I/workdir/I20110113160323
chmod: getting new attributes of `updateSite': No such file or directory
chmod: getting new attributes of `commonFiles': No such file or directory
chmod: getting new attributes of `compilelogs': No such file or directory
chmod: getting new attributes of `plugins': No such file or directory
chmod: getting new attributes of `org.json_1.0.0.v201011060100': No such
file or directory
chmod: getting new attributes of `repository': No such file or directory
chmod: getting new attributes of `features': No such file or directory
chmod: getting new attributes of `plugins': No such file or directory
chmod: getting new attributes of `checksum': No such file or directory
chmod: getting new attributes of `ip_logs': No such file or directory
chmod: getting new attributes of `bundles': No such file or directory
rsyncRootPrefix:
buildDirectory: /shared/orbit/projects/orbit-I/workdir
buildLabel: I20110113160323
uploadUser: david_williams
uploadServer: download1.eclipse.org
uploadRemoteDirectory: /home/data/users/david_williams/downloads/tools/orbit/committers/drops
RSYNC to: /home/data/users/david_williams/downloads/tools/orbit/committers/drops/I20110113160323
labelfile: /shared/orbit/projects/orbit-I/workdir/label.properties |
| Unit
Tests: (0)
|
| No Tests Run
|
| This project
doesn't have any tests
|
|
|
| Modifications
since last successful build: (4)
|
| modified
| lkirchev
| /org.eclipse.orbit/org.eclipse.orbit.releng/maps/bundles.map
| 1.558
| 2011-01-13T16:01:23
| Change entry for gogo bundle
to explicitly list the field names.
|
| modified
| hmalphett
| /org.eclipse.orbit/org.eclipse.orbit.releng/maps/bundles.map
| 1.557
| 2011-01-13T09:34:49
| Correctly updated the feature
which I had missed on the tag v201101120552.
Retagged the feature as v201101120932 and forcing a new build.
It is expected to fail as not all problems are solved yet.
|
| modified
| lkirchev
| /org.eclipse.orbit/org.eclipse.orbit.releng/maps/build.cfg
| 1.203
| 2011-01-13T08:25:36
| Update tag of org.apache.felix.gogo.runtime.
Change the tag in build.cfg to use a version of buildutilities.xml in which
org.apache.felix.gogo.runtime is excluded from pre-pack-conditioning.
|
| modified
| lkirchev
| /org.eclipse.orbit/org.eclipse.orbit.releng/maps/bundles.map
| 1.556
| 2011-01-13T08:25:36
| Update tag of org.apache.felix.gogo.runtime.
Change the tag in build.cfg to use a version of buildutilities.xml in which
org.apache.felix.gogo.runtime is excluded from pre-pack-conditioning. |
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev
