Re: [openmq-dev] Step "Update imqenv.conf file" of 1_openmq-build-and-st

[arjan tijms <arjan.tijms@xxxxxxxxx>]

Hi,

That one came in with the initial commit I think, not sure where it came from before that. If you can do a PR to do the same in the GlassFish project, that would be great indeed.

Might go into GlassFish 6.2.1 then, or potentially 6.2.2.

Kind regards,

Arjan Tijms

On Wed, Jun 30, 2021 at 9:45 AM Piotr Żygieło <piotr@xxxxxxxxxx> wrote:

Hi Team

In the Jenkins job, 1_openmq-build-and-stage, there is step
  # Update imqenv.conf file

It updates the final zip that gets staged and eventually released.

I don't like it for following reasons:
- creation of imqenv.conf is not tracked in original repository
- with the above - the final distribution zip built from sources does
not match the one available in central
- produced config file seems to be dedicated for GF, while OpenMQ
should be considered as a standalone product IMO; such customization
if needed shall be done in consuming project (GF in this case), not in
the one being integrated.

For next release I propose to not perform it here.

Piotrek
_______________________________________________
openmq-dev mailing list
openmq-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/openmq-dev