| Re: [nebula-dev] Opal > Nebula; Balance of the week |
|
Hi Laurent, Yes, but make sure to use the changeid of the first change set. Cheers, Wim From: nebula-dev-bounces@xxxxxxxxxxx [mailto:nebula-dev-bounces@xxxxxxxxxxx]
On Behalf Of Laurent Caron Hi, Thank you for answer. I did not work on the issues with the change set... If I understand well, I need to "squash" the commits (except the first I pushed), and amend last commit ? Thanks Laurent 2018-02-21 17:36 GMT+01:00 Wim Jongman <wim.jongman@xxxxxxxxxxxxxxxxxx>: Hi Laurent, We do not have a set process. Committers normally do this themselves. However, if you like me to
look at the code then just add me as a reviewer. Did you resolve the issues with all the different change sets? Cheers, wim From:
nebula-dev-bounces@xxxxxxxxxxx [mailto:nebula-dev-bounces@xxxxxxxxxxx]
On Behalf Of Laurent Caron Hi, The documentation on the wiki has been "upgraded" : - Additional link added on the top of the pages to go back to the main Nebula page - TOC added after the "introduction" section - Change URL for the link(s) to the snippets to make them shorter Now I would like to know how to process the next steps: I've got many branches pushed on Gerrit (one for Java 8 upgrade, others for new components). In my company, you can not merge a branch into master until 2 developpers have checked/reviewed the code. What is the policy on nebula project ? Thank you and hace a nice day, Laurent 2018-02-20 17:35 GMT+01:00 Laurent Caron <laurent.caron@xxxxxxxxx>: Hi Wim, Thank you for your encouragements :) I've noticed your change, and I moved the TOC on all other pages (it's a good idea !)
Cheers, Laurent 2018-02-19 8:44 GMT+01:00 Wim Jongman <wim.jongman@xxxxxxxxx>: Hi Laurent, You are on a roll. Fantastic work. I have updated one of your wiki pages a bit [1]: * The TOC is moved below the short widget introduction * The Snippet links below are formatted to not show the complete link. Let me know what you think of these changes so that we can do the other widgets as well. On Sat, Feb 17, 2018 at 11:25 PM, Laurent Caron <laurent.caron@xxxxxxxxx> wrote:
|