[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [mylyn-reviews-dev] Changing the icon for comment annotations in the compare editor
|
The ruler extension is provided by the reviews framework and hence intentionally uses the generic icon which is specified in the plugin.xml of the o.e.m.review.ui bundle. I wouldn't recommend using a branded icon for rulers and markers to avoid inconsistencies between reviews connectors and to avoid confusion about the meaning of the icon. The early versions of the Gerrit connector used the branding icon as a placeholder since we didn't have a better icon, yet. Does that make sense?
Steffen
On Wed, Oct 12, 2011 at 3:01 PM, Steffen Pingel
<steffen.pingel@xxxxxxxxxxx> wrote:
The latest weeky build should be using a generic glasses icon for markers:
344107: decorate gerrit tasks with review icon
Please feel free to file a bug if that doesn't work for you.
Thanks,
Steffen
--
Steffen Pingel
Committer,
http://eclipse.org/mylynSenior Developer,
http://tasktop.com