Re: [mylyn-reviews-dev] .project and .classpath files in repository

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

Thanks for cleaning up the .gitignore files Sascha. I didn't realized
that the .settings folders never left my workspace. I have now pushed
them to the repository and opened this bug to track the discussion:

 334848: define common coding conventions and formatting rules for Mylyn Reviews
 https://bugs.eclipse.org/bugs/show_bug.cgi?id=334848

Steffen


On Wed, Jan 19, 2011 at 12:16 PM, Sascha Scholz <sascha.scholz@xxxxxxxxx> wrote:
> I'll check if we can get the project files with maven nature in
> without disturbing users that don't use m2eclipse. But this can't be
> done for all projects because there are hierarchically sorted pom.xml
> files. As far as I remember also egit has (under certain
> circumstances) problems with this setup. I propose that we create
> separate *_parent projects for these to have a flat structure.
>
> Sascha
>
> On Wed, Jan 19, 2011 at 8:37 PM, Steffen Pingel
> <steffen.pingel@xxxxxxxxxxx> wrote:
>> I think there is a big advantage in having everyone work with the same
>> settings, particularly for the classpath. All Eclipse projects I have
>> worked with have had .project and .classpath checked in. Is there a
>> good reason not to include them?
>>
>> For Mylyn we have always had common .settings files which ensures
>> proper compile time checking, common API tooling settings etc. and
>> unified code formatting which I find crucial when working in
>> (distributed) teams. To me the particular formatting rules are less
>> important as long as they are they same across the entire project.
>>
>> I already applied the standard Mylyn rules to all Gerrit connector
>> plug-ins a while ago. Can you check if these work for you?
>>
>> Steffen
>>
>>
>> On Wed, Jan 19, 2011 at 7:32 AM, Lohre, Jan <jan.lohre@xxxxxxx> wrote:
>>> Hi,
>>>
>>> +1 for no .project and .classpath files.
>>>
>>> That you list .settings reminds me of something: We should decide on formatting rules and save actions.
>>>
>>> I would opt for the eclipse default formatting but with 100 or 120 line width and auto format as save action.
>>>
>>> Kind regards,
>>> Jan
>>>
>>>> -----Original Message-----
>>>> From: mylyn-reviews-dev-bounces@xxxxxxxxxxx [mailto:mylyn-reviews-dev-
>>>> bounces@xxxxxxxxxxx] On Behalf Of Sascha Scholz
>>>> Sent: Mittwoch, 19. Januar 2011 14:02
>>>> To: Mylyn Reviews Project
>>>> Subject: [mylyn-reviews-dev] .project and .classpath files in
>>>> repository
>>>>
>>>> Hi,
>>>>
>>>> do we want them to be in the repository or in .gitignore?
>>>>
>>>> Currently, not all projects have them checked in.
>>>>
>>>> I vote for no .project and .classpath files in the repository because
>>>> I prefer to use m2eclipse for all projects. And unless we have project
>>>> specific non-default configuration I would even ignore files in
>>>> .settings.
>>>>
>>>> Sascha
>>>> _______________________________________________
>>>> mylyn-reviews-dev mailing list
>>>> mylyn-reviews-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>> _______________________________________________
>>> mylyn-reviews-dev mailing list
>>> mylyn-reviews-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>>
>>
>>
>>
>> --
>> Steffen Pingel
>> Committer, http://eclipse.org/mylyn
>> Senior Developer, http://tasktop.com
>> _______________________________________________
>> mylyn-reviews-dev mailing list
>> mylyn-reviews-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>



-- 
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com