[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [mylyn-dev] How to replace PersonProposalProvider?
|
Hi,
the first one is an easy fix. I'll do that
The point about the 'id' requires a new design since the interface
between PersonProposalProvider and the connector is
through a Map<String, String>, when probably should be a
List<IRepositoryPerson>
George
On 2022-12-19 09:33, Alexander Fedorov wrote:
Hi,
If you already know the exact code to fix why not to make the next
step?
Would you mind to create an issue so we can discuss the proposed
changes in details?
If it could be followed by PR then it would be fantastic.
Here is the how to contribute guide https://github.com/eclipse-mylyn/.github/blob/main/CONTRIBUTING.md
Regards,
AF
12/19/2022 8:21 PM, George Lindholm
пишет:
On 2022-12-19 04:16, Wim Jongman
wrote:
Do you mean in an existing connector or in a connector
that you are going to make yourself.
In general, but at the moment for my jira connector.
There are some problems with PersonProposalProvider that I would
like to address.
The one that is affecting me the most at the moment is
'matchesSubstring()' which is doing 'startsWith()' instead of
'contains()'
Other problems that I'm able to work around, but is ugly, is the
assumption that the 'id' is has human attributes associated with
it.
This is fine when the id is an account which, most/some of the
time, can be directly associated with a person, but with
Jira Cloud the id is a random string of characters, and offering
them as an select option is meaningless.
'getPrettyName()' also suffers from this assumption.
Thanks
George
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev
