RE: [mylar-dev] Re: CVS API changes yesterday

["Mik Kersten" <beatmik@xxxxxxx>]

Those are good points Felix.  To address them we have pulled out the
optional facilities that a connector should implement.  Providing offline
support requires optionally implementing IOfflineTaskHandler, and for
providing attachment handling an IAttachmentHandler.  You may find the
corresponding contexts useful:

146362: extract offline synchronization from AbstractRepositoryConnector
https://bugs.eclipse.org/bugs/show_bug.cgi?id=146362

146017: Context saving/retrieval in custom repository connectors should be
easier
https://bugs.eclipse.org/bugs/show_bug.cgi?id=146017

One thing that we wanted to do is pull out the new task creation facilities
into ITaskCreationHandler, but wondered if that was overkill.  Please reply
if you have a preference there.  More comments below:

> -----Original Message-----
> From: mylar-dev-bounces@xxxxxxxxxxx [mailto:mylar-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Felix Schwarz
...
> I stumbled several times over the AttributeFactory. One example (where
> I can't ignore it so easily) is getContextAttachments in
> AbstractRepositoryConnector. This method should return
> Set<RepositoryAttachment>.
> 
> And RepositoryAttachment does rely heavily on AttributeFactory (as it
> is an AttributeContainer). Imho it would be better just to return a
> set of something similar to the old IRemoteContextDelegate than
> requiring to return a RepositoryAttachment with all the stuff it
> implies.

These dependencies are now gone.

> Another thing that I don't like in the implementation of
> RepositoryAttachment/AttributeContainer is that everything is stored
> in Strings internally. Maybe its just personal taste but we had this
> type of design here some months ago and it was just horrible. At the
> end nearly everything was thrown away and redone. To be fair: The old
> implementation was done by people who didn't like unit testing. Now we
> are using Java types everywhere (a Date is a Date, is a Date, ...) and
> works _much_ better!

I agree, and what's going on right now is that the offline support
implementation is surfacing too much because we simply pulled it up (whereas
ITask has proper typing).  We'll be looking at this as part of the following
task:

138041: migrate to generic task attributes
https://bugs.eclipse.org/bugs/show_bug.cgi?id=138041

Try this out and let us know if there are any problems.  There's a new dev
build available and 0.5.3 should go out on Monday.  

Mik