| RE: [mylar-dev] Could some take a look at my patch and apply it if itis OK |
|
Hi I have resolved the following reports that
you filed and applied patches where applicable: https://bugs.eclipse.org/bugs/show_bug.cgi?id=128569
https://bugs.eclipse.org/bugs/show_bug.cgi?id=124259
https://bugs.eclipse.org/bugs/show_bug.cgi?id=128570
https://bugs.eclipse.org/bugs/show_bug.cgi?id=130434 https://bugs.eclipse.org/bugs/show_bug.cgi?id=130697
https://bugs.eclipse.org/bugs/show_bug.cgi?id=128747
Comments are on each report. I have
also updated the following to be more clear on how to create patches that can
be applied quickly: http://www.eclipse.org/mylar/doc/devref.php#contributing-patches
Thanks again for the code quality and
performance suggestions. If you are interested in making further code
quality suggestions/patches, these would be most valuable on the mylar.tasklist
and mylar.bugzilla components. All of the context related stuff is due for
a revision in the 0.6 timeframe. For both cases unit test coverage is
key, and in general most patches should come with a passing unit test that
specifies their change to the current behavior, or a failing test that
specifies a reported problem with the current behavior. Mik From:
mylar-dev-bounces@xxxxxxxxxxx [mailto:mylar-dev-bounces@xxxxxxxxxxx] On Behalf Of bin Wang Recently, I create some patches. Since I modified a few files, when I
create a new patch, I often forget some files. In adition, after applying these
patches, it is easy for me to create another patch. Thanks very much. |