[mylar-dev] refactoring MylarPlugin#getStructureBridge

["bin Wang" <wangbin777@xxxxxxxxx>]

In general, from java code convention, we should use "? :"  if it is possible. I strongly recommend this code style.
 

 

From

 public IMylarStructureBridge getStructureBridge(Object object) {
  if (!CoreExtensionPointReader.extensionsRead)
   CoreExtensionPointReader.initExtensions();

  IMylarStructureBridge bridge = null;
  // if (bridges.size() == 0) {
  // MylarStatusHandler.log("no bridges installed", this);
  // return DEFAULT_BRIDGE;
  // }
  for (IMylarStructureBridge structureBridge : bridges.values()) {
   if (structureBridge.acceptsObject(object)) {
    bridge = structureBridge;
    break;
   }
  }
  if (bridge != null) {
   return bridge;
  } else {
   if (defaultBridge != null && defaultBridge.acceptsObject(object)) {
    return defaultBridge;
   } else {
    return DEFAULT_BRIDGE;
   }
  }
 }

to

 public IMylarStructureBridge getStructureBridge(Object object) {
  if (!CoreExtensionPointReader.extensionsRead)
   CoreExtensionPointReader.initExtensions();

  for (IMylarStructureBridge structureBridge : bridges.values()) {
   if (structureBridge.acceptsObject(object)) {
    return structureBridge;
   }
  }
  
  // use the default if not finding
  return (defaultBridge != null && defaultBridge.acceptsObject(object))
    ? defaultBridge
       : DEFAULT_BRIDGE;
 }