| Re: [milo-dev] Netty LEAK message |
Hi Kevin,
Thank you very much.
Actually, yesterday, when confirming whether forget to release()
the ByteBuf instance returned by the three static methods of BufferUtil.java,
we made similar changes and ran it.
However, we did not do the following correspondence in that case.
List<ByteBuf> chunkBuffers.forEach(ByteBuf::release);
In the result, a similar LEAK message appeared. However, I will replace
the presented ChunkDecoder.java and try it.
The following log was output after log of time stamp of
"2017-12-12 04:27:15,159+JST" sent yesterday.
According to this, from the following Hint log,
- UaTcpServerAsymmetricHandler#0
- UaTcpServerSymmetricHandler#0
- DefaultChannelPipeline$HeadContext#0
In the above, there seems to be a possibility of leakage of buffer.
Hint: 'UaTcpServerAsymmetricHandler#0' will handle the message from this point.
Hint: 'UaTcpServerSymmetricHandler#0' will handle the message from this point.
Hint: 'DefaultChannelPipeline$HeadContext#0' will handle the message from this point.
Also, although the relationship with LEAK is unknown, ByteBuf#order(ByteOrder)
added in Netty 4.0 has been deprecated since 4.1.
Sorry for the long mail.
---
2017-12-12 09:42:25,652+JST �d�å org.eclipse.milo.opcua.stack.core.channel.ChunkDecoder decode - expected sequence number 153227 but received 153228
2017-12-12 09:42:25,659+JST �d�å org.eclipse.milo.opcua.stack.core.channel.ChunkDecoder decode - 4d5347466200000011000000e30000 008c5602008c56020001003a030500 00200000002c24564f27ab50a32d2d 85b11d2c67c08dfc3141bff0d7c067 c0998ef946934bd0a17c19e272d301 6f56020000000000ffffffffa86100 0000000000000000
2017-12-12 09:42:25,659+JST �d�å org.eclipse.milo.opcua.stack.server.handlers. UaTcpServerSymmetricHandler lambda$1 - Error decoding symmetric message: expected sequence number 153227 but received 153228
UaException: status=Bad_SecurityChecksFailed, message=expected sequence number 153227 but received 153228
at org.eclipse.milo.opcua.stack.core.channel.ChunkDecoder. decode(ChunkDecoder.java:115)
at org.eclipse.milo.opcua.stack.core.channel.ChunkDecoder. decodeSymmetric(ChunkDecoder. java:66)
at org.eclipse.milo.opcua.stack.server.handlers. UaTcpServerSymmetricHandler. lambda$1( UaTcpServerSymmetricHandler. java:176)
at org.eclipse.milo.opcua.stack.core.channel. SerializationQueue.lambda$1( SerializationQueue.java:58)
at org.eclipse.milo.opcua.stack.core.util.ExecutionQueue$ PollAndExecute.run( ExecutionQueue.java:107)
at java.util.concurrent.Executors$RunnableAdapter. call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask. java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker( ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run( ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
2017-12-12 09:44:18,411+JST �d�å io.netty.util.internal.logging.Slf4JLogger error - LEAK: ByteBuf.release() was not called before it's garbage-collected. See http://netty.io/wiki/ reference-counted-objects.html for more information.
Recent access records: 76
#76:
io.netty.buffer.AdvancedLeakAwareByteBuf. release( AdvancedLeakAwareByteBuf.java: 955)
io.netty.buffer.CompositeByteBuf$Component. freeIfNecessary( CompositeByteBuf.java:1670)
io.netty.buffer.CompositeByteBuf.deallocate( CompositeByteBuf.java:1935)
io.netty.buffer.AbstractReferenceCountedByteBu f.release( AbstractReferenceCountedByteBu f.java:116)
io.netty.buffer.SwappedByteBuf.release( SwappedByteBuf.java:1026)
io.netty.buffer.WrappedByteBuf.release( WrappedByteBuf.java:1029)
io.netty.buffer.AdvancedLeakAwareByteBuf. release( AdvancedLeakAwareByteBuf.java: 951)
org.eclipse.milo.opcua.stack.server.handlers. UaTcpServerAsymmetricHandler. lambda$2( UaTcpServerAsymmetricHandler. java:277)
org.eclipse.milo.opcua.stack.core.channel. SerializationQueue.lambda$1( SerializationQueue.java:58)
org.eclipse.milo.opcua.stack.core.util.ExecutionQueue$ PollAndExecute.run( ExecutionQueue.java:107)
java.util.concurrent.Executors$RunnableAdapter. call(Executors.java:511)
java.util.concurrent.FutureTask.run(FutureTask. java:266)
java.util.concurrent.ThreadPoolExecutor.runWorker( ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run( ThreadPoolExecutor.java:617)
java.lang.Thread.run(Thread.java:748)
#75:
io.netty.buffer.AdvancedLeakAwareByteBuf. getInt( AdvancedLeakAwareByteBuf.java: 189)
io.netty.buffer.CompositeByteBuf._getInt( CompositeByteBuf.java:802)
io.netty.buffer.AbstractByteBuf.readInt( AbstractByteBuf.java:767)
io.netty.buffer.SwappedByteBuf.readInt( SwappedByteBuf.java:581)
io.netty.buffer.SwappedByteBuf. readUnsignedInt( SwappedByteBuf.java:591)
io.netty.buffer.WrappedByteBuf. readUnsignedInt( WrappedByteBuf.java:581)
io.netty.buffer.AdvancedLeakAwareByteBuf. readUnsignedInt( AdvancedLeakAwareByteBuf.java: 442)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder.decodeUInt32( BinaryDecoder.java:114)
org.eclipse.milo.opcua.stack.core.types.structured. OpenSecureChannelRequest. decode( OpenSecureChannelRequest.java: 109)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder.decodeMessage( BinaryDecoder.java:388)
org.eclipse.milo.opcua.stack.server.handlers. UaTcpServerAsymmetricHandler. lambda$2( UaTcpServerAsymmetricHandler. java:265)
org.eclipse.milo.opcua.stack.core.channel. SerializationQueue.lambda$1( SerializationQueue.java:58)
org.eclipse.milo.opcua.stack.core.util.ExecutionQueue$ PollAndExecute.run( ExecutionQueue.java:107)
java.util.concurrent.Executors$RunnableAdapter. call(Executors.java:511)
java.util.concurrent.FutureTask.run(FutureTask. java:266)
java.util.concurrent.ThreadPoolExecutor.runWorker( ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run( ThreadPoolExecutor.java:617)
java.lang.Thread.run(Thread.java:748)
#74:
io.netty.buffer.AdvancedLeakAwareByteBuf. getInt( AdvancedLeakAwareByteBuf.java: 189)
io.netty.buffer.CompositeByteBuf._getInt( CompositeByteBuf.java:802)
io.netty.buffer.AbstractByteBuf.readInt( AbstractByteBuf.java:767)
io.netty.buffer.SwappedByteBuf.readInt( SwappedByteBuf.java:581)
io.netty.buffer.WrappedByteBuf.readInt( WrappedByteBuf.java:571)
io.netty.buffer.AdvancedLeakAwareByteBuf. readInt( AdvancedLeakAwareByteBuf.java: 436)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder.decodeInt32( BinaryDecoder.java:94)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder. decodeByteString( BinaryDecoder.java:169)
org.eclipse.milo.opcua.stack.core.types.structured. OpenSecureChannelRequest. decode( OpenSecureChannelRequest.java: 108)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder.decodeMessage( BinaryDecoder.java:388)
org.eclipse.milo.opcua.stack.server.handlers. UaTcpServerAsymmetricHandler. lambda$2( UaTcpServerAsymmetricHandler. java:265)
org.eclipse.milo.opcua.stack.core.channel. SerializationQueue.lambda$1( SerializationQueue.java:58)
org.eclipse.milo.opcua.stack.core.util.ExecutionQueue$ PollAndExecute.run( ExecutionQueue.java:107)
java.util.concurrent.Executors$RunnableAdapter. call(Executors.java:511)
java.util.concurrent.FutureTask.run(FutureTask. java:266)
java.util.concurrent.ThreadPoolExecutor.runWorker( ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run( ThreadPoolExecutor.java:617)
java.lang.Thread.run(Thread.java:748)
#73:
io.netty.buffer.AdvancedLeakAwareByteBuf. getInt( AdvancedLeakAwareByteBuf.java: 189)
io.netty.buffer.CompositeByteBuf._getInt( CompositeByteBuf.java:802)
io.netty.buffer.AbstractByteBuf.readInt( AbstractByteBuf.java:767)
io.netty.buffer.SwappedByteBuf.readInt( SwappedByteBuf.java:581)
io.netty.buffer.WrappedByteBuf.readInt( WrappedByteBuf.java:571)
io.netty.buffer.AdvancedLeakAwareByteBuf. readInt( AdvancedLeakAwareByteBuf.java: 436)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder.decodeInt32( BinaryDecoder.java:94)
org.eclipse.milo.opcua.stack.core.types.enumerated. MessageSecurityMode.decode( MessageSecurityMode.java:61)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder. decodeEnumeration( BinaryDecoder.java:397)
org.eclipse.milo.opcua.stack.core.types.structured. OpenSecureChannelRequest. decode( OpenSecureChannelRequest.java: 107)
org.eclipse.milo.opcua.stack.core.serialization.binary. BinaryDecoder.decodeMessage( BinaryDecoder.java:388)
org.eclipse.milo.opcua.stack.server.handlers. UaTcpServerAsymmetricHandler. lambda$2( UaTcpServerAsymmetricHandler. java:265)
org.eclipse.milo.opcua.stack.core.channel. SerializationQueue.lambda$1( SerializationQueue.java:58)
org.eclipse.milo.opcua.stack.core.util.ExecutionQueue$ PollAndExecute.run( ExecutionQueue.java:107)
java.util.concurrent.Executors$RunnableAdapter. call(Executors.java:511)
java.util.concurrent.FutureTask.run(FutureTask. java:266)
java.util.concurrent.ThreadPoolExecutor.runWorker( ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run( ThreadPoolExecutor.java:617)
java.lang.Thread.run(Thread.java:748)
#72:
io.netty.buffer.AdvancedLeakAwareByteBuf. getInt( AdvancedLeakAwareByteBuf.java: 189)
io.netty.buffer.CompositeByteBuf._getInt( CompositeByteBuf.java:802)
io.netty.buffer.AbstractByteBuf.readInt( AbstractByteBuf.java:767)
io.netty.buffer.SwappedByteBuf.readInt(