Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [microprofile-wg] JWT 2.0 Specification Release Review - comments

Thanks Roberto, I'll stage MP JWT 2.0 again once MP 2.3 reaches Maven Central.

Sergey

On Mon, Nov 15, 2021 at 6:59 PM Roberto Cortez via microprofile-wg <microprofile-wg@xxxxxxxxxxx> wrote:
Hi,

The licenses were missing in previous versions as well. This is because the LICENSE file was only being added into the main sources and these binaries refer to the test sources.

I’ve adjusted the Parent POM to take into account if a test sources exists and add the LICENSE if required.

Additionally, I believe that we shouldn’t use the test sources to place the TCK files (I’ve seen other MP projects in the same situation). This just adds additional setup to run the TCK, plus these test are not meant to be executed from the project directly.

Cheers,
Roberto

On 15 Nov 2021, at 18:05, Sergey Beryozkin <sberyozkin@xxxxxxxxx> wrote:

Hi Emily

Thanks, I could've opened myself - but was not certain the list you typed here was the final one

Cheers, Sergey

On Mon, Nov 15, 2021 at 5:53 PM Emily Jiang <emijiang6@xxxxxxxxxxxxxx> wrote:
Hi Sergey,

I have logged this issue to detail the problem. 

Thanks
Emily



On Mon, Nov 15, 2021 at 3:08 PM Sergey Beryozkin <sberyozkin@xxxxxxxxx> wrote:
Hi Emily

Thanks,
On Mon, Nov 15, 2021 at 11:47 AM Emily Jiang via microprofile-wg <microprofile-wg@xxxxxxxxxxx> wrote:
Hi Sergey,

Thank you Roberto and Sergey for looking into this! Further to Sergey's email, I double checked the WG ssue and artifacts and have the following comments:
1. the link to the tck jar on the issue #105 needs to be updated to point to the new staging https://oss.sonatype.org/content/repositories/orgeclipsemicroprofile-1543
Will fix it, sure
 
2. The following jars have no license files attached:
microprofile-jwt-auth-tck-2.0-test-javadoc.jar 
microprofile-jwt-auth-tck-2.0-test-sources.jar
microprofile-jwt-auth-tck-2.0-tests.jar

As far as I recall all the license requirements have been checked well before, at the MP JWT RC2 release time. So I'm not sure why the problems have started appearing now.
 
I think the Javadoc jar should have EF license while the -sources and -tests jars should have Apache V2 license as they only contain source files.
 
The above needs to be investigated before a WG can be restarted.

Can you please open an MP JWT issue with the requirements ?

Cheers, Sergey

Thanks
Emily


On Sat, Nov 13, 2021 at 12:08 PM Sergey Beryozkin <sberyozkin@xxxxxxxxx> wrote:
I've staged MP JWT 2.0 release again at


The new staged release includes Roberto's fix (the license in the API jar) and the release notes for MP JWT 2.0 have been aligned correctly.
I can't start a new ballot - I'd appreciate if the staged repository could be checked and the new ballot started

Thanks, Sergey

On Fri, Nov 12, 2021 at 10:38 PM Sergey Beryozkin <sberyozkin@xxxxxxxxx> wrote:
It is my fault since I staged the final release, sorry about it.
Licenses were looked at during the RC releases so the fact the API jar should've had it too was not obvious.
Thanks, Sergey


On Fri, Nov 12, 2021 at 7:59 PM Roberto Cortez via microprofile-wg <microprofile-wg@xxxxxxxxxxx> wrote:
Ok, let's close the current Ballot and a redo the release.

Thank you everyone and sorry for the inconvenience.

Cheers,
Roberto

On 12 Nov 2021, at 12:20, Edwin Derks <ederks85@xxxxxxxxx> wrote:

+1 on respinning.

Apparently I have missed this detail

On Fri, 12 Nov 2021 at 12:33, Emily Jiang via microprofile-wg <microprofile-wg@xxxxxxxxxxx> wrote:
+1 on respining this and starting the ballot again.
Thanks
Emily

On Fri, Nov 12, 2021 at 1:02 AM Roberto Cortez via microprofile-wg <microprofile-wg@xxxxxxxxxxx> wrote:
Hi Kevin,

Sorry for the date, wrong copy paste :)

Not sure what happened in MP JWT. For what I can tell, it never had a license in the API Jar. Apparently we let it through in the last ballot.

I believe no one else depends on JWT, so we can redo the release to fix this.

Cheers,
Roberto

On 11 Nov 2021, at 17:34, Kevin Sutter <sutter@xxxxxxxxxx> wrote:

Hi Roberto,
No vote from IBM yet...  I just posted this tothe Issue, but the API jar file is missing a License file.  I'm pretty sure that would be a requirement for a release.  I know we've been lenient with "extra" licenses that could be cleaned up later.  But, not having any license in the API jar file seems problematic.

Also, a nit...  Your Subject line is good with the voting deadline (Nov 23), but the text in the note says the deadline is April 1.  Maybe that was an early April Fool's joke?  ;-)

---------------------------------------------------
Kevin Sutter
STSM, Jakarta EE and MicroProfile architect @ IBM
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn:
https://www.linkedin.com/in/kevinwsutter

Part-time schedule: Tue, Wed, Thu (off on Mon and Fri)




From:        "Roberto Cortez via microprofile-wg" <microprofile-wg@xxxxxxxxxxx>
To:        "Microprofile WG discussions" <microprofile-wg@xxxxxxxxxxx>
Cc:        "Roberto Cortez" <radcortez@xxxxxxxxx>
Date:        11/09/2021 15:59
Subject:        [EXTERNAL] [microprofile-wg] [BALLOT] JWT 2.0 Specification Release Review - VOTE by Nov 23 (two weeks)
Sent by:        "microprofile-wg" <microprofile-wg-bounces@xxxxxxxxxxx>




To approve and ratify the Release Review of MicroProfile JWT 2.0 Specification, the Steering Committee Representatives vote is requested. Please respond with +1 (positive), 0 (abstain), or -1 (reject).  Any feedback that you can provide to support your vote will be appreciated.

The MicroProfile Specification Process requires the Specification Committee and the Community to provide feedback during the approval process using the relevant documents:

https://github.com/microprofile/microprofile-wg/issues/105

This ballot will be fourteen days, ending on Thursday, April 1st. The ballot requires a Super-majority positive vote of the Steering Committee members. There is no veto. Community input and Community votes are welcomed. However, only the votes delivered by Steering Committee Representatives will be counted.

--
Thank you
Roberto Cortez on behalf of MicroProfile Steering Committee
_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg





_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg


--
Thanks
Emily

_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg
_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg

_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg
_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg


--
Thanks
Emily

_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg


--
Thanks
Emily

_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg

_______________________________________________
microprofile-wg mailing list
microprofile-wg@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/microprofile-wg

Back to the top