Re: [microprofile-dev] Issue with the Fault Tolerance 4.1 Open Telemetry

[Don Bourne <dbourne@xxxxxxxxxx>]

Apologies for opening the issue referenced below at the last minute. When I first looked at the proposed MP FT metrics I hadn’t spent enough time using the new OTel metrics to understand everything that needed to be specified (to be consistent with semantic conventions and to avoid gotchas with Histograms). Working with the metrics in our own Open Liberty features I gained a clearer understanding of how best to use each metric – which led me to come back to the MP FT spec to make sure we were doing things correctly. I would also recommend option 1 or 2 from Andrew’s note.

 

Don Bourne

 

From: microprofile-dev <microprofile-dev-bounces@xxxxxxxxxxx> on behalf of Andrew Rouse via microprofile-dev <microprofile-dev@xxxxxxxxxxx>
Date: Friday, July 26, 2024 at 10:39 AM
To: microprofile-dev@xxxxxxxxxxx <microprofile-dev@xxxxxxxxxxx>
Cc: Andrew Rouse <ANROUSE@xxxxxxxxxx>
Subject: [EXTERNAL] [microprofile-dev] Issue with the Fault Tolerance 4.1 Open Telemetry metrics

Hi,

Just as we're coming up to release, we've had an issue raised about the
new Open Telemetry metrics added in Fault Tolerance 4.1:
https://github.com/eclipse/microprofile-fault-tolerance/issues/639

When we added the integration of Open Telemetry metrics, we used our
existing integration with MP Metrics as a guide. However, we didn't
realise that while both APIs have many of the same concepts (counters,
gauges, histograms etc.) the details between the two are quite
different and some of the choices we made for MP Metrics are not the
right choices for Open Telemetry metrics.

The changes being suggested aren't huge, but they're not trivial
either. I think I could have a PR ready in a few days, and then it
would take another few days to get the changes merged into OpenLiberty
and built before we could create another CCR.

Given that we're trying to get MP 7.0 released, I think the options
are:

1. Delay MP 7.0 again so that this issue can be addressed
2. Remove MP Fault Tolerance 4.1 from MP 7.0 (and include Fault
Tolerance 4.0 instead)
3. Release MP Fault Tolerance 4.1 in its current state (which would
require a breaking change to fix these problems in a later release)

The only change in MP Fault Tolerance 4.1 is the addition of these Open
Telemetry metrics, so personally I would prefer one of the first two
options, rather than releasing it with these issues.

Andrew Rouse


Unless otherwise stated above:

IBM United Kingdom Limited
Registered in England and Wales with number 741598
Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
_______________________________________________
microprofile-dev mailing list
microprofile-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/microprofile-dev