Re: [mdht-dev] Java Version, code style, and source

[Dave Carlson <dcarlson@xxxxxxxxxxxxxxx>]

Sean,

So, what have you decided on the process for updating eclipse git repo for 'cda' module?  I have not done anything with the 'cda' module in eclipse git, as I thought you intended to submit a new copy of code for IP review??   

OK, I will make changes to 'fhir' module for Java 1.8 and add MDHT format style settings.  I am committing all changes to 'master', which is consistent with process I've seen on all other eclipse.org projects. 

I've been looking into the attach-sources and attach-javadocs.  I did not include these in each plugin pom, as I thought they were already in the module parent pom for 'core' and 'fhir'.  I copied a subset of the module pom content from Papyrus.  I see that they use tycho-source-plugin, which seems to have similar function as maven-source-plugin.

  https://eclipse.org/tycho/sitedocs/tycho-source-plugin/plugin-source-mojo.html

There is also a tycho documentation plugin that may have similar or improved functionality with the maven javadoc plugin?

  https://www.eclipse.org/tycho/sitedocs-extras/tycho-document-bundle-plugin/plugin-info.html

We can add this to each module pom and should not need to add into each plugin pom.

Dave

On Mon, Feb 15, 2016 at 4:16 PM, Sean Muir <sean.w.muir@xxxxxxxxx> wrote:

Yes we had set 1.8 as a minimum mostly due to the up public updates for 1.7

Just so we do not duplicate updates - i can work on core and cda to get them to use 1.8 and have the same formatter

if you want take care of fhir

Thanks

Sean

On Feb 15, 2016, at 6:12 PM, Dave Carlson <dcarlson@xxxxxxxxxxxxxxx> wrote:

Sean,

For 'core' and 'cda' plugins in Eclipse git, the code format settings and java version are unchanged from when the github freeze copy was taken and submitted to Eclipse IP for review and initial approval.  For FHIR plugins, I used default format settings, but should add the MDHT code formatting.

Have we all agreed that Java 1.8 is now the required minimum version for all MDHT modules?  If so, I will make that setting in the fhir plugin manifests.  The Hudson builds are using Java 1.8.

Dave

On Mon, Feb 15, 2016 at 3:12 PM, sean.muir@xxxxxxxxxxxxxxx <sean.muir@xxxxxxxxxxxxxxx> wrote:

Dave -
        I noticed we are still not consistent with the plugins using the same java version and code formatter
I assume we are java 1.8 and reusing the formatting from MDHT ?

        I also noticed that not all of plugin projects have the java docs and attach source in the pom
Was this intentional ?

Thanks

Sean


_______________________________________________
mdht-dev mailing list
mdht-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdht-dev

_______________________________________________
mdht-dev mailing list
mdht-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdht-dev

_______________________________________________
mdht-dev mailing list
mdht-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdht-dev