Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-users] Integration of maven bundle-plugin, inlined dependencies, visibility of dependencies from tycho projects 
Have a look at m2e/tycho integration [1].

I strongly recommend setting up integration test(s) first, so you can
better understand desired behaviour. Existing m-b-p integration tests
are in MavenBundlePluginTest, and test projects used by this tests are
in
org.sonatype.tycho.m2e.tests/projects/maven-bundle-plugin/embed-dependency.

In particular, make sure you understand the desired classpath and
classpath access rules for all projects involved. There is fundamental
difference between how PDE and m2e work -- PDE enforces classpath
visibility on the provider end, but m2e can only enforce visibility on
the consumer end (otherwise non-OSGi consumers will break). I do not
know if Embed-Dependency;inline=true can be implemented properly because
of this limitation.

But before you invest any significant time in this, make sure that you
and/or your employer will be able to accept Sonatype CLA [2]. We will
not be able to accept patches larger than 200 LOC without signed CLA on
file.

[1] https://github.com/sonatype/m2eclipse-tycho
[2] http://www.sonatype.org/SonatypeCLA.pdf

--
Regards,
Igor

On 11-12-16 7:17 AM, Markward Schubert wrote:

Thanks for the quick reply!

I can not promise anything,  as I don't know if i understand things
under the hood of eclipse enough, but which projects would I have to
have a look at to check if i can contribute something? Is this core m2e?

2011/12/16 Igor Fedorenko <igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>

    <Embed-Dependency>...;inline=__true</Embed-Dependency> is not
    supported. I
    didn't need it yet and can't tell when/if it will be added. We do
    welcome quality patches (provided you are willing to sign our CLA).

    --
    Regards,
    Igor

    On 11-12-16 6:32 AM, Markward Schubert wrote:

        Hi!

        I was following the discussion between David and Igor in
        http://dev.eclipse.org/__mhonarc/lists/m2e-users/__msg01950.html
        <http://dev.eclipse.org/mhonarc/lists/m2e-users/msg01950.html>, as I
        thought I have a pretty similar situation here.

        We have a server- and a client-part of our product. I want to
        aggregate
        those projects of the server-part which are ALSO needed on the
        client-side into ONE bundle, to be able to identify this as THE
        INTERFACE of our server from the client's perspective, rather than
        having a bunch of bundles together being 'the interface'. By
        aggregating
        I mean to let maven aggregate the packages of different other
        projects
        into this 'artificial' bundle and still be able to see them with
        workspace-resolution from PDE-built projects.

        This did not work with the currently released versions of
        eclipse and
        m2e, but it worked fine with the versions mentioned in
        http://dev.eclipse.org/__mhonarc/lists/m2e-users/__msg01950.html
        <http://dev.eclipse.org/mhonarc/lists/m2e-users/msg01950.html>.
        So just to
        give everybody hope, who is waiting for this to work: It worked
        with the
        current milestones of PDE and m2e when the dependencies were
        declared to
        be embedded!

        Now my question: Originally we integrated our interface-project's
        classes by inlining them into the artificial interface-bundle by
        simply
        working with <Export-Package>. But also after upgrading to the
        mentioned
        versions, inlined (or i should better say "to be inlined at
        package-time") classes can not be seen by the eclipse
        build-system. Only
        the content of projects, defined to be embedded with
        <Embed-Dependency>
        is seen by the eclipse build-system.

        Is there any known status of the capabilities of the
        m2e-bundle-plugin-integration concerning inlined dependencies?

        Regards,
        Markward


        PS: This whole m2e/tycho thing is great work and it is a
        pleasure to see
        how things constantly improve even more over the time! Thanks to all
        contributors!

    _________________________________________________
    m2e-users mailing list
    m2e-users@xxxxxxxxxxx <mailto:m2e-users@xxxxxxxxxxx>
    https://dev.eclipse.org/__mailman/listinfo/m2e-users
    <https://dev.eclipse.org/mailman/listinfo/m2e-users>




_______________________________________________
m2e-users mailing list
m2e-users@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-users

Back to the top