Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lsp4j-dev] Building of GitHub PRs on Jenkins
Thanks!

Miro

On 23. Aug 2018, at 21:19, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

Hi folks,

Pull Requests against the LSP4J repo will now automatically trigger Jenkins to build the Pull Request. Please let me know if you have any issues/questions. This is what I added to the Contribution guide:

Jenkins PR Build

The Jenkins CI job builds and tests pull requests. All member of the GitHub Eclipse organisation should have their PRs built automatically as the whole organisation is on the whitelist. All other PRs need to be approved before they are built for the first time. To approve a PR you have to be an admin and say:

  • "ok to test" to accept this pull request for testing
  • "test this please" for a one time test run
  • "add to whitelist" to add the author to the whitelist

If the build fails for other various reasons you can rebuild.

  • "retest this please" to start a new build

See full documentation for the GitHub Pull Request plug-in for Jenkins. To see the current list of Admins, visit the configuration -> Build Triggers -> GitHub Pull Request Builder -> Admin list. All LSP4J committers can add their GitHub username to that list.

The Pull Request Builder polls the GitHub repo at 5 minute intervals, so there may be a short delay before the check shows up as Pending on GitHub.

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
_______________________________________________
lsp4j-dev mailing list
lsp4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/lsp4j-dev

--
Dr. Miro Spönemann
Software engineer and consultant

TypeFox GmbH
Am Germaniahafen 1, 24143 Kiel

Tel.: +49 151 42679459

Sitz: Kiel, Registergericht: Amtsgericht Kiel, HRB 17385
Geschäftsführer: Sven Efftinge, Moritz Eysholdt, Dr. Jan Köhnlein

Back to the top