Hi Mickael,
I tried to do the change to submit a patch but I found some problems.
I cloned the repository, and right after it I did a mvn verify and found some test failing (4 always and 1 sometimes)
Failures:
ColorTest.testColorProvider:57
ColorTest.testColorProviderExternalFile:76
DiagnosticsTest.testDiagnosticsOnExternalFile:191
HighlightTest.testCheckIfOtherAnnotationsRemains:141
RenameTest.testRenameHandlerEnablement:85 <=== this sometimes
My environment:
- Tried with JDK 8 (AdoptOpenJDK and Oracle) and 11 (AdoptOpenJDK)
- Maven 3.6.3
- macOS Mojave 10.14.6
Is there any special supported development environment? It seems strange to have these failures. I went to the CI for the project and I saw just 1 of them but found others:
I have debugged the ColorTest and found what's happening (the red value of the RGB needs to be changed from 56 to 55 due to rounding issues and the text needs to be larger than just "a" for both tests otherwise the box with the color seems to be not rendered properly in its position) but I suspect that changing it will break on CI.
Do you know what could be happening?
Thanks in advance!
Martin
