Re: [lsp4e-dev] Doubt regarding add support features

[Ayush Krishna Murthi <kmayush27399@xxxxxxxxx>]

Hi,

I was observing prepareRename bug by going through commits. I found, in LSPRenameHandler file, there is already function like isEnabled() which check whether Language Service access, textSelection and Renaming is possible or not. Then, isn't need of prepareRename already fulfilled ? I think the main aspect of prepareRename feature is to check whether rename textDocument/rename can be executed or not. Please correct me if i am on wrong path.

Sorry, I wasn't able to give much time in recent and i will be bit occupied as my semester exam beginning from next week. Hope to connect after exam that ends on 8th May. Still i will try to learn Stream API and solve this bug in this time.

Thanks everyone for helping me out even in small misinterprets and thanks Mickael Istria sir, you been a great mentor and instructor. Working on this project is a great learning experience. Hope to work at Eclipse under GSoC. Irrespective of GSoC, i will try to contribute to this project in my free time :) 

Thanks & Regards

Ayush

On Tue, Apr 2, 2019 at 1:28 PM Mickael Istria <mistria@xxxxxxxxxx> wrote:

Hi Ayush,

I think the best think is that you look at the Git history and find an commit that has an interesting description for you to study it.

A git commit like "6f48292b40bb66593790e8c11415722cdeb9c4e3 / Bug 525271 give some feedback on rename operations to the user" could be a good way to see how the rename request/responses can be orchestrated.

For preparerRename, it involves finding the right time to call it, with which parameters (the specification tells most of it), and then retrieving the resust of the invocation and decide of what to do in the IDE with it.

_______________________________________________
lsp4e-dev mailing list
lsp4e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/lsp4e-dev