Re: [lsp4e-dev] Regarding doubt on blocker bugs

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Hi Ayush,

Can you be a little bit more specific on your question. Which line are you talking about. The link you provided refers me to line 333 where the socket is opened without try-with-resources block. If that is what you are referring to I would be interested in another way of handling it. By catch function I assume you are referring to the catch block on line 340. AFAIK the comment there (ignore inner resource exception) is correct but misleading. 

Any improvement to that code is welcome, please add me as reviewer on gerrit.

Thanks

Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On Tue, 19 Mar 2019 at 16:58, Ayush Krishna murthi <kmayush27399@xxxxxxxxx> wrote:

Presently working on sonarcloud blocker bugs - on this file. What should be inside the catch function should it be aborted with message or log error or blank,

Thanks

_______________________________________________
lsp4e-dev mailing list
lsp4e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/lsp4e-dev