Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lsp4e-dev] API Compatibility? 
Yes, will keep it separate.

FWIW, I published two proposals here:
  https://git.eclipse.org/r/97496 Refactor plug-in activator into internal package.
  https://git.eclipse.org/r/97497 Add null-annotations to plug-in activator

Let me know if that is not desired and I can drop them.

-Gunnar

-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/






> On 18. May 2017, at 12:21, Mickael Istria <mistria@xxxxxxxxxx> wrote:
> 
> On Thu, May 18, 2017 at 9:05 PM, Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx> wrote:
> Would it make sense to refactor some obviously "internal" stuff into an "internal" package?
> 
> Why not, but...
> I'd rather find more meaningful and feature-oriented package name and export only those which contain only public APIs. What about we create an "org.eclipse.lsp4e.connection" package containing the APIs (which should only be the classes to provide the stream) and export only this one? Does that seem better to you or do you prefer "internal"? Both are fine, but if we both prefer the same one, it's even better ;)
> Just note that as opposed to Platform, I'd like LSP4E to try to have a policy to export as minimal things as possible, even if they are marked as internal. I believe for such a relatively simple project, it would encourage more people to contribute directly to LSP4E whereas exposing internals would let people work on extensions on their side too easily when they could contribute to the project directly, or at least be forced to share their use-cases to encourage LSP4E to open up more APIs.
> Anyway, if you're working on this as well, please try to keep both tasks (adding the feature you have in mind and renaming packages) separated in different somehow independent commits.
> 
> Cheers,
> _______________________________________________
> lsp4e-dev mailing list
> lsp4e-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/lsp4e-dev

Back to the top