I don’t think this should be a hard rule from the onset. We should make the recommendation and correct committers when not following the rule. In the future we can begin enforcing this more strictly. The important point will be that existing committers strictly
follow the rule. It will be much easier to enforce if we can cite how existing team members are using commit messages.
--Dave
|
This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing |
Feedback |
Honestly I see it as a suggestion we can do to contributors. But I don’t think we will be able to strictly apply this rule and pass through all the PRs and commits to verify that everyone is compliant with 50 or 72 characters maximum.
In my opinion we should try to attract people and ease their process of contribution instead of making things difficult.
Just my 2 cents :-)
Matteo
|
This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing |
Feedback |
I'm fine with this and if David agrees too I think we can update CONTRIBUTING.md with this recommendation.
Ciao,
Cristiano
First I would write it down and communicate that change.
Then I would see some period of time where people need to be educated of that change.
Then I would differentiate between committers and contributors. Committers are deeper involved into the project and should follow project rules. So I would suggest they do amend their PRs, which is pretty easy anyway.
For contributors we could educate them and still accept the PR. if they want to amend the PR, fine. If contributions come in more frequently they should follow the same rules.
So to answer you question: In the end, yes. But not right away, not without explanation and not without having exceptions.
_______________________________________________
kura-dev
mailing list
kura-dev@xxxxxxxxxxx
To
change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kura-dev
_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/kura-dev
|