| Re: [kura-dev] CoAP support in Kura through Eclipse Californium |
Hi Buddhika,
There must be something wrong. If you changed only a few lines that patch must be very small.
If I've understood correclty you only changed two pom files, right?
Try the following:
1. Clone a fresh Kura repository
2. Make the changes you want to submit as a patch
3. issue 'git diff' to see the differences between the working copy and the head. They should be limited to the files you changed (they can be read in the diff output).
3. commit your changes (git commit -a -m "Fixed...")
4. issue 'git log' and find the SHA of your commit e.g: 27abf1f59ee0bb852ee49042ead4b324fc659e46
5. Format the patch again with git format-patch -1 27abf1f59ee0bb852ee49042ead4b324fc659e46
It's content should be similar to the output of git diff of step 3
Otherwise, just send me the files you have changed.
Ciao,
Cristiano
On 18/06/2014 15:29, Buddhika Dilhan wrote:
Hi Christiano,I cleaned the repo and created the patch in the command line. but the patch was same size as it before. so I created the patch using eclipse IDE that weighted 1.1 MB.when I try to send it, it gave an error saying that git patch contains a line longer than 998 characters solutionI used --no-validate command and sent the e mail to the mailing list by using smtp.gmail server.I hope its ok.
thanks
Buddhika DilhanUndergraduate,Department of Computer Science and Engineering,University of Moratuwa.
On Wed, Jun 18, 2014 at 11:44 AM, De Alti, Cristiano <Cristiano.DeAlti@xxxxxxxxxxxx> wrote:
Hi Buddhika,
There is something wrong with your second patch (0002): it's 15MB in size.
It looks too much for a few lines patch.
Please recreate the patches starting from a clean kura repository.
Your patch should only contain hunks for the file you changed.
Patches are usually sent to mailing lists using git-send-email:
http://git-scm.com/docs/git-send-email
This is a workflow I used in the past (to the barebox ML). Study it and adapt it to your needs:
Send patches to the ML:
git send-email --smtp-server=smtp.live.com --smtp-server-port=587 --smtp-encryption=tls --smtp-user=<your username> --smtp-pass=<your password> 0001-cfi_flash.c-correct-calculation-of-region-erasesize-.patch
Make sure the patch is signed-off by you
Thanks,
Cristiano
Da: kura-dev-bounces@xxxxxxxxxxx <kura-dev-bounces@xxxxxxxxxxx> per conto di Buddhika Dilhan <buddhika.dilhan5@xxxxxxxxx>
Inviato: mercoledì 18 giugno 2014 04.17
A: Kura Developers mailing list
Oggetto: Re: [kura-dev] CoAP support in Kura through Eclipse Californiumhi,my message is being held as it is too big. it is waiting for moderators approval.is there any thing I can do for it??thanks
Buddhika DilhanUndergraduate,Department of Computer Science and Engineering,University of Moratuwa.
_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/kura-dev
_______________________________________________ kura-dev mailing list kura-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/kura-dev
--
Cristiano De Alti
Principal Software Engineer
direct: +39 0433 485468
EUROTECHImagine.Build.Succeed.HEADQUARTERSEUROTECH S.p.A. – Via Fratelli Solari, 3/a | 33020 Amaro UD | Italy | Tel. +39. 0433 485411 | Fax +39. 0433 485499 |Cap. Soc. 8.878.946,00 € I.V. | P.IVA / C.F.: IT 01791330309 | REA Udine 196115
www.eurotech.com
____________________________________
Il presente messaggio ed ogni suo allegato sono da intendersi inviati esclusivamente agli effettivi destinatari e potrebbero essere soggetti a restrizioni legali. Se avete ricevuto questo messaggio per errore vi invitiamo a darne immediata notifica al mittente e cancellarlo dal vostro sistema. Qualsiasi altro uso di questo messaggio da parte vostra e' strettamente proibito.This e-mail, and any file attached to it, is meant only for the intended recipient of the transmission and may be a communication privileged by law. If you have received it in error, please notify the sender immediately and delete the original from your system. Any other use of this e-mail by you is strictly forbidden.____________________________________Per favore, pensate all’ambiente prima di stampare questa e-mail. Please consider the environment before printing this e-mail.
_______________________________________________
kura-dev mailing list
kura-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/kura-dev
From 317d8b62fb2aa62bd7dd12bd3638335cfb8cfbe0 Mon Sep 17 00:00:00 2001
From: buddhika <buddhika.dilhan5@xxxxxxxxx>
Date: Sun, 22 Jun 2014 06:25:47 +0530
Subject: [PATCH 158/158] Fixed
---
kura/org.eclipse.kura.web/pom.xml | 37 +++++++++++++++++++------------------
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/kura/org.eclipse.kura.web/pom.xml b/kura/org.eclipse.kura.web/pom.xml
index affbf97..bd1e752 100644
--- a/kura/org.eclipse.kura.web/pom.xml
+++ b/kura/org.eclipse.kura.web/pom.xml
@@ -207,24 +207,7 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>properties-maven-plugin</artifactId>
- <version>1.0-alpha-1</version>
- <executions>
- <execution>
- <phase>compile</phase>
- <goals>
- <goal>read-project-properties</goal>
- </goals>
- <configuration>
- <files>
- <file>${basedir}/../distrib/build.properties</file>
- </files>
- </configuration>
- </execution>
- </executions>
- </plugin>
+
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
@@ -355,6 +338,24 @@
<plugins>
<!--This plugin's configuration is used to store Eclipse m2e settings
only. It has no influence on the Maven build itself. -->
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>properties-maven-plugin</artifactId>
+ <version>1.0-alpha-1</version>
+ <executions>
+ <execution>
+ <phase>compile</phase>
+ <goals>
+ <goal>read-project-properties</goal>
+ </goals>
+ <configuration>
+ <files>
+ <file>${basedir}/../distrib/build.properties</file>
+ </files>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
<plugin>
<groupId>org.eclipse.m2e</groupId>
<artifactId>lifecycle-mapping</artifactId>
--
1.9.1