Re: [jta-dev] Pull request reviews by non-committers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [jta-dev] Pull request reviews by non-committers

From: Tom Jenkinson <tom.jenkinson@xxxxxxxxxx>
Date: Wed, 10 Jun 2020 15:13:38 +0100
Delivered-to: jta-dev@xxxxxxxxxxx
List-archive: <https://www.eclipse.org/mailman/private/jta-dev>
List-help: <mailto:jta-dev-request@eclipse.org?subject=help>
List-subscribe: <https://www.eclipse.org/mailman/listinfo/jta-dev>, <mailto:jta-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://www.eclipse.org/mailman/options/jta-dev>, <mailto:jta-dev-request@eclipse.org?subject=unsubscribe>

I raised an issue about discussing merge conditions for a PR: https://github.com/eclipse-ee4j/jta-api/issues/100

On Mon, 8 Jun 2020 at 17:01, Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:

Hi,

I have received a review from a person that is not a committer to the Jakarta Transactions project on a pull request [1]. However, unless I hear any objection by Thursday 11th June, 2020 I intend to merge the pull request.

I think we should also add something to https://github.com/eclipse-ee4j/jta-api/blob/master/CONTRIBUTING.md to formalise these kind of conditions.

If you are a committer [2] to Jakarta Transactions and would like to provide a review in the meantime, that would be appreciated too.

Thanks!
Tom

[1] https://github.com/eclipse-ee4j/jta-api/pull/97
[2] https://projects.eclipse.org/projects/ee4j.jta/who

References:
- [jta-dev] Pull request reviews by non-committers
  - From: Tom Jenkinson

Prev by Date: Re: [jta-dev] Requesting a review
Next by Date: [jta-dev] Request for help converting the Jakarta Transactions specification document
Previous by thread: [jta-dev] Pull request reviews by non-committers
Next by thread: [jta-dev] Requesting a review
Index(es):
- Date
- Thread

Breadcrumbs