Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jsp-dev] CI for JSP 3.0?
Hi,

Just to be absolutely sure, I refreshed 3.0.0 IMPL as 3.0.0 API was refreshed the other day. See https://jakarta.oss.sonatype.org/content/repositories/staging/org/glassfish/web/jakarta.servlet.jsp/3.0.0/

Kind regards,
Arjan Tijms

On Wed, Oct 21, 2020 at 2:52 PM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:
Hi,

The standalone scripts used by Jenkins typically patch GlassFish with the staged CI. That means no respin of GlassFish is needed. It's this part of the Jenkins pipeline:

 stage ("Replace API and IMPL in GF") {
        env.API_JAR_NAME = "${API_JAR_NAME}"
        env.IMPL_JAR_NAME = "${IMPL_JAR_NAME}"
        env.DOWNLOAD_API_JAR_NAME = "${DOWNLOAD_API_JAR_NAME}"
        env.DOWNLOAD_IMPL_JAR_NAME = "${DOWNLOAD_IMPL_JAR_NAME}"
        sh '''#!/bin/bash -ex
            #rm $javaee_home/glassfish/modules/${API_JAR_NAME}
            #cp -v ${WORKSPACE}/download/${API_JAR_NAME} $javaee_home/glassfish/modules
            #cp -v ${WORKSPACE}/download/${IMPL_JAR_NAME} $javaee_home/glassfish/modules
            '''
    }


(btw, not sure how it survived the 60 days, but that's another issue).

Just to be sure I can restage 3.0.0 IMPL first, and then just run the TCK from Jenkins again.

Kind regards,
Arjan Tijms



On Wed, Oct 21, 2020 at 2:43 PM Kevin Sutter <sutter@xxxxxxxxxx> wrote:
Hi,
Paul and I were trying to complete the Specification PR for JSP 3.0.  One of the items is a Certification Request which needs to show a Compatible Implementation successfully implementing the Spec and executing the TCK.

I talked with Scott Marlow and he provided me with links to a good Glassfish run that showed the JSP CI successfully executing against the JSP TCK.  Unfortunately, it was pointed out that the API and/or CI that was pulled into Glassfish at this point was the RC1 version, not the final staged version.

So, the question to this team is how can we get a successful CI to run against the TCK by Friday?  A respin and re-release of a Glassfish RC won't happen until Monday.  We need to finish up these non-Platform PRs by Friday.  Previously, we had identified Apache Tomcat as a CI.  Is that still in play for the final CI?  Or, do we need to use the JSP Impl, which gets merged into GF?  Just looking for ideas on how to proceed.

Thanks!

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn: https://www.linkedin.com/in/kevinwsutter
_______________________________________________
jsp-dev mailing list
jsp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jsp-dev

Back to the top