Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jsonp-dev] [External] : JsonProvider.JSONP_PROVIDER_FACTORY potential breaking change in JSON-P 2.1?
  • From: Lukas Jungmann <lukas.jungmann@xxxxxxxxxx>
  • Date: Sat, 26 Feb 2022 09:30:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BcRYAXPq0R3EgdFzJg68ld1/KMe88Xpp0EjoDRmse5s=; b=X2rklTubPhx2golDV+HFmJ/KWgJNHsU6ksWK7dN0zey1Bq1LDQ/zblcxtaBiR1WuMzFPtbL2iTz9MzMMuBwZvI+sGmf/AVR8tJvD/CfK2ZFVB5qxk96zJXyt9sPo1CsqsFHPvCRuZ2KKalpkAOmdt9ixMfkPauhkxKszpgsaqlLHuqvd+AMf8JQ9j8T8T7LQSQBGvIQXKLOU5cpIUTiXWwzaItYfy7j0D1lj06jX6Yb7kbzs7mSgLcv4PohsgJf1fThMrL/bo9P2Pdvr3T5v37WT6UBsI8HDuXCwWCrrVez7fiNmaLr4+2I7A9czMQg4PbLtwiFlgrGoZb1dRw/Ehg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vqf61JQ1nUclXRPT3YK0L3x0cjQY5d0gxtLWFnvcd/V41XnVGgYU3mRSyw9CM3gdFnSBU6VlKuSafuNJ9g+82NMDrbT0J/+brvRTcsThHvga1RgJ/C5VS/ewwfJy21yGDuGBf47Ukn0zyT1cZHiHCimW2eVlSB4YAqLilIRmaKrWyGfnqrx4ibi4HelpW0jlGAE+XGg7yT9bFVd0tE+VFzbxSizrX8c0uSQhWmasfkQXsMFh+k0OClWas7WzF+ricU8jgn0+anu2DTF2yU2uQXBCAQb/ZvYgLu9oZlFZmElsGzQy8+v+oDAlhliHgyti4KYv141TcHvxyD4mPXMcAg==
  • Delivered-to: jsonp-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/jsonp-dev/>
  • List-help: <mailto:jsonp-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=unsubscribe>
  • User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1

Hi,


On 2/25/22 6:25 PM, Nathan Rauh wrote:
Hi,

While trying to identify what is new in EE 10 for JSON-P,


there are multiple ways to easily (I hope!) find that out before the release gets published:

release record: https://projects.eclipse.org/projects/ee4j.jsonp/releases/2.1

spec index page (through the spec pr): https://github.com/jakartaee/specifications/pull/432

project on GH: https://github.com/eclipse-ee4j/jsonp/projects/1

and lastly the diff: https://github.com/eclipse-ee4j/jsonp/compare/2.0.0...2.1.0-RELEASE


However, the switch to from public to private visibility seems like a mistake given that it continues to be referenced from public JavaDoc within the same class,

@value uses the actual value of the constant being referenced, see the documentation/man of javadoc for more details on this. Or have you found the constant name anywhere in the _generated_ javadoc and not just in sources?

but yes, I see no problem in moving the constant back to public, even though I believe that the real impact of this change is rather limited (close to zero)


thanks,
--lukas


Back to the top