Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jsonp-dev] [External] : Re: Volunteer to apply a package rename to TCKs to avoid `jakarta` namespace in test classes...
  • From: Lukas Jungmann <lukas.jungmann@xxxxxxxxxx>
  • Date: Tue, 11 Jan 2022 23:04:17 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GxuJaKG2nxkjL0gRfnUyER1TyhLnOms8Zt8OQsiK6E4=; b=L+O1eHiRVGL+kWRCBhz2fZWOmH561bBww4pLXOjqVCqVb5zHl/PsdlBipN/n+RINK2hjIgY3+9FqDhmq3XolirrWRfU5STNxMzxk0reOEoz8W7MQcLwA1duH5lreS2x27N1MAU1kgIS6pq1cpI91QXS+JmEI713zv77Vxf1nn9MdYMqyil9MMgJl+xr3Lcyk6+Tm/MYkphixEYmILU6FPavR7QtdMDjvoSa5hcblVW5pRjIOz2pmKJfyOhUB9i2Ovm+vwV0sVDSgSpqC8EhefrarF/C/gRJ4Ar66ROOeskmiHR4j2W0srPbn8iTzCbZ0gZk+s7JhRUrXWRuNyjf1mA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPSs8+6Azu3RKN9uBttbbCG29pSOHjr8XFhjHCSI3KuT1N0zXnv+iNA4z8X8w2RuMhNgViTZhQyf0jFq5BVd7AsLhG1VzITRGWA4280KZTVYZ96tDSgg3iJDDjBQIKSTp5t1WlaIcaZFYB/cicvdnRpyb2uf2gaaBddvf8heS+CkOuOgxL/sMRqadMz7PtYvH2JztUJuF3a7xFbfek2Yla3HtVHJoc3TiraE6GmhVZKxgKZs5/+Cxf1gy63gNIcSeEx0NS8ClpcfQ0EB+8KF2whOOGd8NwX53JgV9VkMOrr36KFLTp17MHxQu01PMmVw7EVqVIibRuQauIOEqLF+Ig==
  • Delivered-to: jsonp-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/jsonp-dev/>
  • List-help: <mailto:jsonp-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHYBz1Pd0JJ2aVBjkG9rHNy9bQtxaxecKMd
  • Thread-topic: [jsonp-dev] [External] : Re: Volunteer to apply a package rename to TCKs to avoid `jakarta` namespace in test classes...
Ooops, my bad, sorry, I should have checked my notes on a good old piece of paper before responding. The right version is the latest snapshot, or 1.1.0 which needs to be built. Something is still trying to get before that step, no idea why O:-)

Thanks,
—lukas

11. 1. 2022 v 23:48, Scott Marlow <smarlow@xxxxxxxxxx>:



updating parsson version to 1.0.0 helped, except that I see some failures with and without my changes:

[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ClientTests.jsonParserCurrentEvent:1862 NoSuchMethod 'jakarta.json.stream.Json...
[ERROR]   ClientTests.testDuplicateKeysFirst:3214 NoClassDefFound jakarta/json/JsonConfi...
[ERROR]   ClientTests.testDuplicateKeysLast:3233 NoClassDefFound jakarta/json/JsonConfig...
[ERROR]   ClientTests.testDuplicateKeysNone:3194 NoClassDefFound jakarta/json/JsonConfig...
[ERROR]   ClientTests.jsonNumber21Test:347 NoSuchMethod 'jakarta.json.JsonNumber jakarta...
[INFO]
[ERROR] Tests run: 177, Failures: 0, Errors: 5, Skipped: 0

I'll create a draft pr with the changes so far.

On 1/11/22 4:28 PM, Lukas Jungmann wrote:
Use either -Psnapshots or update parsson version to 1.0.0 (in staging)

thanks,
—lukas

11. 1. 2022 v 21:56, Scott Marlow <smarlow@xxxxxxxxxx>:




On 1/11/22 2:44 PM, Scott Marlow wrote:

Hi,

Following up on the Platform ML discussion [1] about TCK package names not starting with `jakarta` package for various reasons.  I'm not sure if or when a TCK package rename PR would be merged but wanted to ask if having such a pr would help?  I'll give it a shot if yes.

Perhaps change from `jakarta.json.bind.tck` to `json.bind.tck`?

Perhaps change from jakarta.jsonp.tck` to `jsonp.tck`?

https://github.com/scottmarlow/jsonp/tree/tckrename has some initial possible package rename changes, however building the tck-impl folder fails with "Could not find artifact org.eclipse.parsson:parsson:jar:1.0.1-SNAPSHOT" failure.

Scott

Or something else, perhaps from the now-unofficial survey [2]?

Scott

[1] https://www.eclipse.org/lists/jakartaee-platform-dev/msg03130.html
[2] https://docs.google.com/forms/d/e/1FAIpQLSf2zO8dqSZuehho2kpnot09DPveV_jJpPAzVn93tiQLda54hw/viewform?vc=0&c=0&w=1&flr=0

_______________________________________________
jsonp-dev mailing list
jsonp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jsonp-dev__;!!ACWV5N9M2RV99hQ!dTX5e6suqeIBREERz7phoRJAZfoy8L-pRel9hms6CDA4QL0E7lKbHcAsgW9RTaRjxDg$

_______________________________________________
jsonp-dev mailing list
jsonp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jsonp-dev

Back to the top