Re: [jgit-dev] review removal of deprecated methods before we release 7.

[Matthias Sohn <matthias.sohn@xxxxxxxxx>]

On Mon, Sep 2, 2024 at 1:57 PM Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:

On Mon, Sep 2, 2024 at 12:55 PM David Ostrovsky <david.ostrovsky@xxxxxxxxx> wrote:

Hi Matthias,

Since gerrit change 336887 gitiles should support building with JDK 17 and language level 17.

Have you tried:

  $ bazel build --config=java17 :all

?

Thanks, this worked. I think it's time to remove Java 11 support from gitiles as both Gerrit and JGit bumped to Java 17 on master.

There's one fix [3] necessary to adapt to deprecated RevWalk methods which were removed in [4] which was already submitted.
With this fix the gitiles build and tests all succeed.

Based on these successful tests, could I please get some positive votes on the cleanup series [1] ?

 

[3] https://gerrit-review.googlesource.com/c/gitiles/+/436237

[4] https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/1200306

resending the email since it bounced from the jgit-dev list

 

Thanks

David

Matthias Sohn <matthias.sohn@xxxxxxxxx> schrieb am Mo., 2. Sept. 2024, 10:03:

I tried building gitiles change [1] with its jgit submodule updated to this 7.0 cleanup series [2].

Though `bazelisk build gitiles` fails since JGit 7.0 switched to language level Java 17 and uses some Java features which aren't available in Java 11.

I tried removing the java 11 toolchain from the gitiles build but my bazel foo seems insufficient to get this right.

@David Ostrovsky could you have a look what's missing on top of [1] to switch the gitiles build to Java 17 ?

[1] https://gerrit-review.googlesource.com/c/gitiles/+/428937

[2] https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/1200448

-Matthias

On Sat, Aug 31, 2024 at 12:07 AM Ivan Frade <ifrade@xxxxxxxxxx> wrote:

Thanks for the clean ups!

Gitiles is another candidate to check for trouble.

I will try this stack of changes in a build and see how it goes,

Thanks again,

Ivan

On Fri, Aug 30, 2024 at 1:34 PM Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
>
> I could use some help to review this series
> https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/1200448
> removing deprecated methods before we release 7.0 beginning of next week.
>
> I checked the impact of these removals on EGit (no errors) and Gerrit (2 errors, trivial fix: need to remove 2 methods from DelegateRepository which were removed from Repository).
>
> thanks
> -Matthias