Re: [jgit-dev] Using LFS fails with NPE

["Halstrick, Christian" <christian.halstrick@xxxxxxx>]

Maybe we should throw better exception in this case. An NPE is not appropriate.

 

Ciao

  Chris

From: <jgit-dev-bounces@xxxxxxxxxxx> on behalf of Duft Markus <Markus.Duft@xxxxxxxxxxxxxxxx>
Date: Wednesday, 14. March 2018 at 16:39
To: Mark Waite <mark.earl.waite@xxxxxxxxx>, "jgit-dev@xxxxxxxxxxx" <jgit-dev@xxxxxxxxxxx>
Subject: Re: [jgit-dev] Using LFS fails with NPE

 

In this case, LFS support is not present and/or not active in JGit.

 

“Somebody” needs to call BuiltinLFS.register() once to activate the builtin (optional) LFS code, before using LfsFactory.

 

The JGit CLI does it like this: https://git.eclipse.org/r/#/c/112864/34/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Main.java

 

HTH,

Markus

 

From: jgit-dev-bounces@xxxxxxxxxxx [mailto:jgit-dev-bounces@xxxxxxxxxxx] On Behalf Of Mark Waite
Sent: Wednesday, March 14, 2018 3:20 PM
To: JGit Developers list <jgit-dev@xxxxxxxxxxx>
Subject: [jgit-dev] Using LFS fails with NPE

 

I'm trying to add JGit LFS support to the Jenkins git client plugin to match the existing command line git LFS support.  The LfsFactory.getInstance() returns a non-null, but the getInstallCommand() always returns a null value.

 

What am I missing?

 

Code is at https://github.com/MarkEWaite/git-client-plugin/blob/0a184fe2097249841cf3b598a71046ddf607bddf/src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java#L325

 

The test code which exercises it is "mvn clean -Dtest=GitClientTest test".  

 

Mark Waite

SSI Schäfer IT Solutions GmbH | Friesachstrasse 15 | 8114 Friesach | Austria
Registered Office: Friesach | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht für Zivilrechtssachen Graz