Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] LFS
Markus,

I've experimented with adding a call to InstallLfsCommand into the Jenkins git client plugin.  I see the call being made but haven't gone further with it.  Since git client plugin work is weekend and nights work and I'm traveling for business next weekend, it is unlikely I'll make significant progress on it in the next 2-4 weeks.

Are there other objects and methods I need to use (and study) in order to enable LFS from the JGit implementation in the Jenkins git client plugin?

Thanks,
Mark Waite

On Mon, Mar 5, 2018 at 1:19 AM Duft Markus <Markus.Duft@xxxxxxxxxxxxxxxx> wrote:

Thanks.

 

And thanks everybody for helping me LFS into JGit J Especially all the reviewers of course.

 

I assume there will still be a lot of changes to the support in the future, but there is a basis to build upon now J Please everyone test and feel free to bash me if somethings not working.

 

I will now go on preparing the last bits to integrate into EGit, so we can properly consume this support in Eclipse without manual configuration editing.

 

Cheers,

Markus

 

From: Matthias Sohn [mailto:matthias.sohn@xxxxxxxxx]
Sent: Sunday, March 4, 2018 9:28 PM
To: Mark Waite <mark.earl.waite@xxxxxxxxx>
Cc: Duft Markus <Markus.Duft@xxxxxxxxxxxxxxxx>; JGit Developers list (jgit-dev@xxxxxxxxxxx) <jgit-dev@xxxxxxxxxxx>
Subject: Re: [jgit-dev] LFS

 

On Sun, Mar 4, 2018 at 12:04 PM, Mark Waite <mark.earl.waite@xxxxxxxxx> wrote:

Markus,

 

I've been following the latest changes in JGit 4.11.0-SNAPSHOT.  It now includes LFS changes.

 

I was a little surprised that InstallLfsCommand.setRepository() is not returning "this".  That makes it so I cannot use:

 

    InstallLfsCommand cmd = new InstallLfsCommand();

    cmd.setRepository(repo).call();

 

Instead, I need to use:

 

    InstallLfsCommand cmd = new InstallLfsCommand();

    cmd.setRepository(repo);

    cmd..call();

 

Is that expected?

 

pushed

for review to fix this

 

-Matthias 

SSI Schäfer IT Solutions GmbH | Friesachstrasse 15 | 8114 Friesach | Austria
Registered Office: Friesach | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht für Zivilrechtssachen Graz

Back to the top