RE: [jdt-ui-dev] [PATCH] fix for inline refactoring bugs #24941 a nd #35

["Stalnov, Dmitry" <dstalnov@xxxxxxxxxxxxx>]

Title: RE: [jdt-ui-dev] [PATCH] fix for inline refactoring bugs #24941 and #35905

Hello Dirk,

I became aware of the org.eclipse.jdt.ui.tests.refactoring project soon after submitting the patch. :) I have already started working on unit tests for my patch and during this work I came across several scenarios when unneeded explicit casts were produced. So, right now I am working on the patch for the patch :) .

I also removed fix for the bug #35905 from the patch attached to the bug report #24941 in BugZilla. I would like to completely finish the patch and unit testing for bug #24941 and only after that continue working on #35905. I expect to complete new patch in the next 3-4 days.

Thanks,
   Dmitry

-----Original Message-----
From: Dirk Baeumer [mailto:dirk_baeumer@xxxxxxxxxx]
Sent: Monday, June 16, 2003 6:36 PM
To: jdt-ui-dev@xxxxxxxxxxx
Cc: 'jdt-ui-dev@xxxxxxxxxxx'; jdt-ui-dev-admin@xxxxxxxxxxx
Subject: Re: [jdt-ui-dev] [PATCH] fix for inline refactoring bugs #24941 and #35905

Hello Dimitry,

thanks for providing the patch for the two bugs. I will look at the patch the next couple of days and will let you know if there is something missing besides test cases for the new functionality ;--).

Are you aware of the org.eclipse.jdt.ui.tests.refactoring projects. It contains all our refactoring tests. So for the new functionality we should have test cases as well. The interesting test case class is InlineMethodTests and the test resources reside in resources/InlineMethodWorkspace/TestCases.

Dirk

                                                                          
             "Stalnov, Dmitry"                                            
             <dstalnov@fusionO                                            
             ne.com>                                                    To
             Sent by:                  "'jdt-ui-dev@xxxxxxxxxxx'"         
             jdt-ui-dev-admin@         <jdt-ui-dev@xxxxxxxxxxx>           
             eclipse.org                                                cc
                                                                          
                                                                   Subject
             06/14/2003 12:13          [jdt-ui-dev] [PATCH] fix for inline
             AM                        refactoring bugs #24941 and #35905 
                                                                          
                                                                          
             Please respond to                                            
             jdt-ui-dev@eclips                                            
                   e.org                                                  
                                                                          
                                                                          

    Hello all,

In our company we use Eclipse as a main tool for Java programming and are very happy with it. I'd like to participate in its development. For a start, to get familiar with the codebase, I decided to fix several bugs. Attached is a patch fixing two refactoring bugs (24941, 35905). Could somebody review it and either apply to CVS or make some comments and suggestions how I can improve the fix?

Thank you in advance,
    Dmitry(See attached file: patch.txt)