Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-dev] Revert Bug 481323 - substring/subword completion

Hi Gunnar, please open a bug for the performance regression and let discuss this there.

Kind regards,
Andrey Loskutov

Спасение утопающих - дело рук самих утопающих

https://www.eclipse.org/user/aloskutov


> Gesendet: Donnerstag, 01. Oktober 2020 um 16:32 Uhr
> Von: "Gunnar Wagenknecht" <gunnar@xxxxxxxxxxxxxxx>
> An: "Eclipse JDT general developers list." <jdt-dev@xxxxxxxxxxx>
> Betreff: [jdt-dev] Revert Bug 481323 - substring/subword completion
>
> Dear JDT Team,
> 
> After making progress with the Java 11 related performance issues, I discovered a huge regression that was introduced in 4.17.
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=481323#c21
> 
> While I see value in substring and subword completion, the performance degradation is not acceptable IMO.
> 
> Here are the timings from SearchableEnvironment#findTypes:
> - as is today: 2134ms
> - with -Djdt.codeCompleteSubstringMatch=false: 1649ms
> - with commit reverted: 794ms
> 
> So even disabling it on the command line does not restore the previous performance.
> 
> Can this be reverted and implemented again in such a way that there won't be any performance hit if it's turned off?
> 
> -Gunnar
> 
> -- 
> Gunnar Wagenknecht
> gunnar@xxxxxxxxxxxxxxx, http://guw.io/
> 
> 
> _______________________________________________
> jdt-dev mailing list
> jdt-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev
>


Back to the top