| Re: [jca-dev] [jakartaee-tck-dev] Connector TCK test deployment failures after updating from connector_1_0.dtd to connector_2_0.xsd |
I have removed the old descriptors from the connectors spec document and we don't have backwards compatibility as a requirement for Jakarta EE 9 so I'd be in favour of removing the old compatibility tests. Let's wait a few days to see if others on the spec dev group also have an opinion on this. Steve -----Original Message----- From: Scott Marlow <smarlow@xxxxxxxxxx> Sent: 27 August 2020 20:15 To: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>; jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx> Cc: jca-dev@xxxxxxxxxxx Subject: Re: [jakartaee-tck-dev] Connector TCK test deployment failures after updating from connector_1_0.dtd to connector_2_0.xsd Steve, Related to the earlier questions about spec-version, the files in question appear to need more than just removing the spec-version. The below source files are part of the testing of old connector versions (I think from the first connector version). Should we remove tests for Connector 1.0 that use the old-whitebox*.rars? I think that the Jakarta Connectors team should help make the decision on this. Relevant source files: https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-notx-param.xml https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-notx.xml https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-tx-param.xml https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-tx.xml https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-xa-param.xml https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-xa.xml If we remove the above files, we will need to also remove the test RARs and update Platform + Connector TCK doc: - old-dd-whitebox-notx-param.rar - old-dd-whitebox-xa-param.rar - old-dd-whitebox-tx.rar - old-dd-whitebox-notx.rar - old-dd-whitebox-xa.rar - old-dd-whitebox-tx-param.rar Since only the previous Jakarta EE version deployment descriptors will be supported (see https://github.com/eclipse-ee4j/jakartaee-platform/pull/236), I think we should delete the old Connector 1.0 compatibility resource archives (as per https://github.com/eclipse-ee4j/jakartaee-platform/pull/236). Scott On 8/27/20 12:19 PM, Steve Millidge (Payara) wrote: > I don’t think the connector team have changed the schema. That schema > was likely changed in bulk to the new namespace. > > From a quick search the connector 1.6 xsd does not have the > spec-version element. >