Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jaxrs-dev] Github Branches

Christian,

 

(a) Maven Best Practice: Because 2.1-SNAPSHOT would be wrong. It must be 2.1.7-SNAPSHOT, as "SNAPSHOT" means before. But you could name it 2.1-Maintenance for example.

 

(b) Git Best Practice: Because we do not need it. Keeping stale branches is an anti-pattern in Git, as tags is the git way for that (Github even indicates stale branches to propose their eager deletion). The names EE4J_8 and 2.1.6 are pointing to the same commit (67ac), and that tag exists exactly for that purpose. Once there is a need to activate that developmen stream again, the needed branch can get recreated in less time than writing this mail: git checkout -b 2.1.7-SNAPSHOT 2.1.6

 

Season's Greetings from Black Forest

-Markus

 

Von: jaxrs-dev-bounces@xxxxxxxxxxx [mailto:jaxrs-dev-bounces@xxxxxxxxxxx] Im Auftrag von Christian Kaltepoth
Gesendet: Samstag, 21. Dezember 2019 07:54
An: jaxrs developer discussions
Betreff: Re: [jaxrs-dev] Github Branches

 

(1) +0

(2) +1

 

If we create a "3.0-SNAPSHOT" branch for 3.0, why don't we just replace the EE4J_8 branch with a "2.1-SNAPSHOT" branch and use it as a maintenance branch?

 

Am Fr., 20. Dez. 2019 um 15:58 Uhr schrieb Markus KARG <markus@xxxxxxxxxxxxxxx>:

(1) There is no need to actually keep a branch for that purpose, as you can easily reconstruct it from the corresponding tag (git checkout -b <NEW-BRANCH> 2.1.6), as branches are for active development, while tags are for archived streams. BTW, note that "-1" means that we MUST NOT remove that branch even if all other contributors would be +1 (e. g. due to that simple git trick), so I'd like to ask if you really mean "-1" or "0" (i. e. "I would like to keep it, but I do not stand in the way of the majority").

Thanks.

-Markus

 

Von: jaxrs-dev-bounces@xxxxxxxxxxx [mailto:jaxrs-dev-bounces@xxxxxxxxxxx] Im Auftrag von Andy McCright
Gesendet: Freitag, 20. Dezember 2019 13:53
An: jaxrs developer discussions
Betreff: Re: [jaxrs-dev] Github Branches

 

(1) -1 

 

I would like to keep that branch around in case we need to do another point release.  This should only mean very minor changes to the spec doc or javadoc, etc, but if we do need to make a correction, it will be a lot easier if the branch is still there.

 

(2) +1

 

Thanks!

 

On Fri, Dec 20, 2019 at 5:21 AM Markus KARG <markus@xxxxxxxxxxxxxxx> wrote:

Committers,

 

(1) The EE4J PMC agreed that we may delete the EE4J_8 branch, as Jakarta EE 8 was published there is no more use of that branch. We need to take care that everything in that branch is also found in the master branch.

 

(2) As the master branch contains new features, it is targeting v3.1. As we need to provide a v3.0 for Jakarta EE 9, I propose we create a new branch "3.0-SNAPSHOT" for that purpose (we cannot call it "3.0" because it would interfer with tag names) as a branch off master and removing the new features manually.

 

If nobody objects, I will perform these changes in my X-mas holidays.

 

Vote, please. :-)

 

-Markus

 

 

 

_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jaxrs-dev

_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jaxrs-dev


 

--


Back to the top