Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jaxrs-dev] Does Draft status count as PR review time?


On Jun 1, 2019, at 8:00 AM, Christian Kaltepoth <christian@xxxxxxxxxxxx> wrote:

I think draft status should count as review time. "Draft" basically just means "Don't merge" yet, so I don't see a reason for not counting it.

 +1

— Santiago


Am Sa., 1. Juni 2019 um 12:17 Uhr schrieb Markus KARG <markus@xxxxxxxxxxxxxxx>:

Our general rule is to have a PR open for review for at least two full weeks.

Meanwhile there is this "Draft" feature new to Github PRs.

How to we treat "Draft" status? Does the "Draft" state count as "review time"?

I would say yes, because a PR is a PR, it can be reviewed and voted, independent of the new "Draft" status.

-Markus

_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jaxrs-dev


--
Christian Kaltepoth

_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jaxrs-dev

Back to the top