Re: [jaxrs-dev] Request for extension to Response

[Santiago Pericas-Geertsen <santiago.pericasgeertsen@xxxxxxxxxx>]

On Nov 27, 2018, at 7:30 PM, Ron Sigal <rsigal@xxxxxxxxxx> wrote:

A number of javax.ws.rs.core.Response methods, e.g., getEntity() and hasEntity(), include a line in the javadoc like

* @throws IllegalStateException in case the response has been {@link #close() closed}.

However, in the absence of a method like isClosed(), we end up writing code like

try {
   if (response.getEntity() != null) return response;
}
catch(IllegalStateException ise) {
   // IllegalStateException from ClientResponse.getEntity() means the response is closed and got no entity
}

instead of

if (!response.isClosed() && response.getEntity() != null) {
   return response;
}

The implementation of isClosed() should be simple, and it leads to nicer code.

 Seems like a reasonable addition to me.

— Santiago