| Andy,
Inlined. Some general thoughts: * I would like to see the type-safe clients built out of ClientBuilder (rather than MP's RestClientBuilder) - we might need to "condense" the build method to include the base URI, but otherwise a client could be generated like: MyClient clientProxy = ClientBuilder.newBuilder().build(baseURI, MyClient.class);
Yes, I think bootstrapping from ClientBuilder makes sense.
* ResponseExceptionMappers - I think this is a great value-add for rest clients - it adds to the type-safety since responses could be mapped to checked exceptions which might make more sense to app developers.
These would be useful for existing non-proxy-based clients also, correct?
* CDI/MP Config support - This might be tricky, but is one of the nicest (IMO) features of MP Rest Client. This allows users to simply inject a rest client, avoiding the builder altogether. The trick is that it would require a dependency on CDI and MP Config (IIUC, the MP Config APIs are also getting moved to JakartaEE, so maybe this isn't a huge problem).
Perhaps this could be left for “phase 2”.
As for next steps, I could attempt to draft up a pull request that pulls in the MP Rest Client APIs into the javax.ws.rs.client.ClientBuilder class. I probably won't have anything to review very soon though - aside from the porting work, I will also need to check on any IP issues.
Sounds good, looking forward to it ;)
— Santiago
_______________________________________________ jaxrs-dev mailing list jaxrs-dev@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/jaxrs-dev
|
