| Re: [january-dev] January-- |
Jonah,
Thanks I will prepare a pull request doing it as you suggest.
Cheerio,
Matt
-----Original Message-----
From: january-dev-bounces@eclipse.org [mailto:january-dev-bounces@eclipse.org ] On Behalf Of Jonah Graham
Sent: 30 January 2017 12:03
To: january developer discussions
Subject: Re: [january-dev] January--
Hi Matt,
Sounds good to me and it follows along the lines from earlier discussions. I think the end goal should be split git repos (taking a page out of xtext itself which has 8 repos now BTW).
So my one change would be to recommend not including datasets in full and calling it something like geometry. The two branches can be treated like two different git repos until we request a second actual git repo from foundation.
Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
On 30 January 2017 at 10:53, <Matt.Gerring@xxxxxxxxxxxxx> wrote:
> Hello,
>
>
>
> I have been trying to live with Pete’s compromise with January, it is
> a very good try, but I can’t. The reason is that it does not address
> the main issues with January having eclipse xtext, forms and other
> fruity dependencies.
>
>
>
> You see in order for people to use January in non-eclipse projects
> they must be able to fork the repo and add improvements and do pull
> requests to merge said improvements. They do not want to deal with
> merging xtext bundles which have nothing to do with their usage of
> January. However today they must do that as these bundles are changed.
>
>
>
> This might seem like an academic point however it is exactly the one
> faced by making CDMA and January work together. There will be features
> required in the Dataset stuff to support CDMA fully. It must be
> possible to (easily) fork a non-xtext/ui dependent version and make modifications.
>
>
>
> Also data acquisition at Diamond is the main user of January, after a
> few conversations today, we prefer it not to be there. There is
> nothing to stop dependencies like this clogging up our server with
> extra bundles (which are there at the moment BTW but that should be solved with the slimmer build).
> The way our build system works it’s pretty easy to inadvertently make
> the dependencies and Buckminster will happily go and check out all that stuff.
>
>
>
> More importantly developers must be able to check out January easily
> on the fly at Diamond because they have to support beamlines. It must
> be possible to check out master and have few dependency issues (xtext
> is a massive one) because we run from binary of january (which is the
> correct approach but it comes with responsibility).
>
>
>
> In the event where a beamline has to fix a defect in this layer, it
> must be easy to import the source from the master of the github repo
> and debug it. I do not want people having to figure out which bundles
> to delete, deal with unexpected dependencies and the inevitable
> confusion at three in the morning on a difficult beamline.
>
>
>
> In short the concrete problems are:
>
> 1. Integration with CDMA (making fork/merge/pull request easy for other
> projects!)
>
> 2. Dependencies (mostly but not completely solved with the separate build
> idea)
>
> 3. Support of beamlines using January
>
>
>
> Perhaps we use branches to solve this for this week?
>
> january/master - vanilla bundles incl. Dataset which can be forked to
> non-eclipse – Supportable at our facility.
>
> january/full - dataset + geom + xtext + forms + etc. – The full
> fast version, available everywhere.
>
>
>
> Also proposed is a separate repo which would be even better but this
> will take a while to set up I think and we would like to deal with the
> support issue fairly quickly.
>
>
>
> Cheerio,
>
>
>
> Matt
>
>
>
>
>
> --
>
> This e-mail and any attachments may contain confidential, copyright
> and or privileged material, and are for the use of the intended
> addressee only. If you are not the intended addressee or an authorised
> recipient of the addressee please notify us of receipt by returning
> the e-mail and do not use, copy, retain, distribute or disclose the
> information in or attached to the e-mail.
> Any opinions expressed within this e-mail are those of the individual
> and not necessarily of Diamond Light Source Ltd.
> Diamond Light Source Ltd. cannot guarantee that this e-mail or any
> attachments are free from viruses and we cannot accept liability for
> any damage which you may sustain as a result of software viruses which
> may be transmitted in or with the message.
> Diamond Light Source Limited (company no. 4375679). Registered in
> England and Wales with its registered office at Diamond House, Harwell
> Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United
> Kingdom
>
>
>
> _______________________________________________
> january-dev mailing list
> january-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/january-dev
>
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/january-dev
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev