Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] I have a conflicting call this week on Wednesday + Persistence/GlassFish status...

Hello,

On 11/19/24 2:17 PM, Arjan Tijms wrote:
Hi,

If GlassFish 7 fails, and we know that GlassFish 7 passes the EE 10 TCK (which presumably has that exact same test, albeit in different form), that would indicate the issue is with the refactoring of the test.

GlassFish 7 also fails.  We need more information though than just that the remove EJB bean JNDI lookup returns null with ejb-link.  Clearly the deployment is incorrect in some way.  If we stay on the current path (option 3), we will need more information as to what is going wrong.

Which option from https://www.eclipse.org/lists/jakartaee-tck-dev/msg02114.html do others think is best?  We should discuss further on the Platform TCK call but if your not attending, please make your suggestions in this thread.

Currently, the lowest hanging fruit might be option 1 (switch to lookup-name and remove the ejb-link) which requires some test updating but possibly done by running global search + replace script against the Persistence tests that depend on appclient. 

Scott


Have you already been able to track down the original EE 10 version of the test that is now failing?

Kind regards,
Arjan Tijms





On Tue, 19 Nov 2024 at 20:12, Scott Marlow <smarlow@xxxxxxxxxx> wrote:


On 11/19/24 1:11 PM, Arjan Tijms wrote:
Hi,

On Tue, 19 Nov 2024 at 15:04, Scott Marlow <smarlow@xxxxxxxxxx> wrote:


On 11/19/24 5:44 AM, Arjan Tijms wrote:
Hi, 
Stay on the current path option 3:

Eventually, we will find the test or GlassFish problem and fix it.  I'm thinking we could try running with a different EE 11 implementation to see if we see different results.

Did you try to run the test against GlassFish 7?

Not really, I just tried the following but seems to be the wrong changes as I get failure:

"
java.io.IOException: Cannot run program "/home/smarlow/tck/platformtck/glassfish-runner/persistence-platform-tck/target/glassfish8/glassfish/bin/asadmin" (in directory "/home/smarlow/tck/pl

atformtck/glassfish-runner/persistence-platform-tck"): error=2, No such file or directory
"

diff --git a/glassfish-runner/persistence-platform-tck/pom.xml b/glassfish-runner/persistence-platform-tck/pom.xml
index 6adf8b70d..d143579ab 100644
--- a/glassfish-runner/persistence-platform-tck/pom.xml
+++ b/glassfish-runner/persistence-platform-tck/pom.xml
@@ -53,13 +53,13 @@
        <derby.user>cts1</derby.user>
        <exec.asadmin>${project.build.directory}/${glassfish.toplevel.dir}/glassfish/bin/asadmin</exec.asadmin>
        <ftable>ctstable2</ftable>
-        <!-- Use JDK17 to run with GF 8.0.0-JDK17-M5 -->
-        <glassfish.version>8.0.0-JDK17-M7</glassfish.version>
        <glassfish.home>${project.build.directory}/${glassfish.toplevel.dir}</glassfish.home>
        <glassfish.lib.dir>${glassfish.home}/glassfish/lib</glassfish.lib.dir>
        <!-- Use JDK21 to run with GF 8.0.0-M5 -->
-        <!-- <glassfish.version>8.0.0-M5</glassfish.version> -->
+        <!-- <glassfish.version>7.0.19</glassfish.version> -->
        <glassfish.toplevel.dir>glassfish8</glassfish.toplevel.dir>
+        <!-- Use JDK17 to run with GF 8.0.0-JDK17-M5 -->
+        <glassfish.version>7.0.19</glassfish.version>

For GlassFish 7 you also need to change the toplevel dir to glassfish7.


Good catch!

https://gist.github.com/scottmarlow/662a70061545c8b917bef6dd0e137e86 has output from adjusted local build and https://github.com/scottmarlow/jakartaee-tck/tree/glassfish7 has the changes.  Still see similar failure with GlassFish 7.



Hope that helps!

Kind regards,
Arjan Tijms



 


        <jakarta.platform.version>11.0.0-M2</jakarta.platform.version>
        <javadb.lib>${glassfish.home}/javadb/lib</javadb.lib>
        <jdbc.classpath>${project.build.directory}/${glassfish.toplevel.dir}/javadb/lib/derbyclient.jar:${project.build.directory}/${glassfish.toplevel.dir}/javadb/lib/derbyshared.jar:${pr
oject.build.directory}/${glassfish.toplevel.dir}/javadb/lib/derbytools.jar</jdbc.classpath>



Kind regards,
Arjan Tijms

 

Scott

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top