Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Our Platform TCK groupId is currently using `jakartatck`, should we change to `jakarta.tck`?

Thanks for the feedback!  https://github.com/jakartaee/platform-tck/pull/1221 was merged to the tckrefactor branch as can be observed in the various pom.xml files (e.g. https://github.com/jakartaee/platform-tck/blob/tckrefactor/pom.xml#L29).

This change may impact some pull requests as well as your tckrefactor local branches which should be updated.  I'm sure there are multiple ways to make the change, one is:
   find -name pom.xml -type f| xargs sed -i 's/jakartatck/jakarta.tck/g'

We might also start thinking about renaming the tckrefactor branch soon as well which deserves a new email thread if someone wants to start that.

Scott


On Mon, Feb 5, 2024 at 4:52 AM Emily Jiang via jakartaee-tck-dev <jakartaee-tck-dev@xxxxxxxxxxx> wrote:
+1
Emily

On Fri, Feb 2, 2024 at 7:09 PM David Matejcek via jakartaee-tck-dev <jakartaee-tck-dev@xxxxxxxxxxx> wrote:
On 02. 02. 24 17:45, Scott Marlow via jakartaee-tck-dev wrote:
"
<parent>
        <groupId>org.eclipse.ee4j</groupId>
        <artifactId>project</artifactId>
        <version>1.0.7</version>
 </parent>

<groupId>jakartatck</groupId>
"

Since the parent pom already mentions `ee` it seems okay to me that the Platform TCK uses groupId=jakartatck currently.  But a better name (<groupId>jakarta.tck</groupId>) is suggested by Scott Stark on helpdesk ticket https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4237#note_1705985 which I gave my +1 to on the issue.

Should we change the Platform TCK from groupdId `jakartatck` to `jakarta.tck`?

Scott

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev


I vote +1 as I really like the idea to have the TCK under this tree: https://repo1.maven.org/maven2/jakarta/


-- 
David Matejcek | OmniFish
david.matejcek@xxxxxxxxxxx
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev


--
Thanks
Emily

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top