Re: [jakartaee-tck-dev] Are the EE 10 Platform TCK rules for controlling

[Scott Marlow <smarlow@xxxxxxxxxx>]

On Wed, Jan 24, 2024 at 10:38 AM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

On Wed, Jan 24, 2024 at 10:18 AM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

https://github.com/jakartaee/platform-tck/blob/10.0.x/src/com/sun/ts/lib/harness/TSTestFinder.java#L243 may be a key part of how we are finding each test method to be run.

We don't seem to be using ^ TSTestFinder for finding the ejb30/* tests but do seem to be using https://github.com/jakartaee/platform-tck/blob/10.0.x/src/com/sun/ts/lib/harness/EETest.java so will  look there for how we determine which ejb30 test class methods to invoke.

We weren't using the ^ TSTestFinder class on my local machine as I needed to delete the jakartaeetck/src/testsuite.jtd file which is a cache of the previous TSTestFinder results.

The answer to my original question is that the https://github.com/jakartaee/platform-tck/blob/10.0.x/src/com/sun/ts/lib/harness/TSTestFinder.java class parses the jakartaeetck/src/com/sun/ts/tests/ejb30/bb/session/stateless/annotation/appexception/annotated/Client.java to determine the contained test methods.  

For example, we are parsing the "testName: atCheckedAppExceptionTest" from https://github.com/jakartaee/platform-tck/blob/master/src/com/sun/ts/tests/ejb30/bb/session/stateless/annotation/appexception/annotated/Client.java#L32 which looks like:

"

/*
   * @testName: atCheckedAppExceptionTest
   *
   * @assertion_ids:
   *
   * @test_Strategy:
   *
   */

"

We do not follow the super classes like https://github.com/jakartaee/platform-tck/blob/master/src/com/sun/ts/tests/ejb30/common/appexception/ClientBase.java#L49 which contains even more tests.

For automating TCK refactoring, we should parse the Client (or similarly named) test client for "@testName:" entries but ignore the same comments in the common super classes.

Scott

 

 

On Fri, Jan 19, 2024 at 8:35 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

On Fri, Jan 19, 2024 at 4:04 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

On Fri, Jan 19, 2024, 3:01 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

Hi,

With the EE 10 Platform TCK, if I run the com.sun.ts.tests.ejb30.bb.session.stateless.annotation.appexception.annotated tests, we only run the "at*" tests such as "atCheckedAppExceptionTest" which I think is the reverse of what the code comment in https://github.com/jakartaee/platform-tck/blob/master/src/com/sun/ts/tests/ejb30/common/appexception/ClientBase.java#L49 indicates "Tests whose name does NOT begin with "at" are for the  /annotated/".  

It would also be helpful to know how to identify other ClientBase classes that have optional tests that are similar.

If this is the only case, we can easily introduce a new ClientBase class that doesn't have optional tests.  The bigger problem is finding all of the ClientBase classes with optional tests.

^ will help us with continuing the refactoring of the Platform TCK.  Thanks all!

Scott

 

Regardless, we need to understand what in the Jakarta EE 10 (and earlier) TCK tests is ensuring that com.sun.ts.tests.ejb30.bb.session.stateless.annotation.appexception.annotated (https://github.com/jakartaee/platform-tck/tree/master/src/com/sun/ts/tests/ejb30/bb/session/stateless/annotation/appexception/annotated) only run the "at" (tests that begin with "at") and the com.sun.ts.tests.ejb30.bb.session.stateless.annotation.appexception.override (https://github.com/jakartaee/platform-tck/tree/master/src/com/sun/ts/tests/ejb30/bb/session/stateless/annotation/appexception/override) tests run the "at" tests plus other tests.  

Are the rules for controlling the filtering of which com.sun.ts.tests.ejb30.bb.session.stateless.annotation.appexception tests to run in the ant script/build.xml files? 

Having the answer will help us to proceed with TCK refactoring. 

Thanks,

Scott