Re: [jakartaee-tck-dev] auto code style?

[Olivier Lamy <olamy@xxxxxxxxxxx>]

On Thu, Nov 24, 2022 at 7:04 AM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:

Hi,

I'm not against using a source formatter but I think more discussion is needed as to which format options to use.  

Note that for the actual source formatting no discussion should be needed anymore. That one was established around the inception of the EE4J and Jakarta EE projects and just codified in formatting files for Eclipse and IntelliJ here:

https://github.com/eclipse-ee4j/ee4j/tree/master/codestyle

That;s great if something has already been discussed/agreed and we can move forward.

I have changed the PR to use this format. 

Now to run it:

mvn -f pom-code-style.xml formatter:format   

Please note the PR is very simple for now. Only make it possible to change the format.

If we have some agreements I can add some profile to run it automatically in Jenkins etc..

side note it would be good to have some project-resources.jar (containing those files https://github.com/eclipse-ee4j/ee4j/tree/master/codestyle) deployed to Maven central so it could be re used and avoid to duplicate those xml configurations in many different places.

 

Kind regards,

Arjan Tijms

--

Olivier