Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] [External] : Jakarta Authentication TCK 3.0.1 staged
Hi,

On Wed, Jul 6, 2022 at 11:50 PM Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Hi Arjan,

 

Thanks, I was able to run all the tests using the latest tck bundle .

 

Glassfish Full profile : https://ci.eclipse.org/jakartaee-tck/job/10/job/jakarta-authentication-tck-3.0.1-glassfish-run/11/  (-Pplatform) (I removed other profiles to run the default)

Glassfish Web profile : https://ci.eclipse.org/jakartaee-tck/job/10/job/jakarta-authentication-tck-3.0.1-glassfish-run/12/  (-Pplatform,web)



  1. I see that the within the old tck build module some plugins (download-ant, build-old-tck and install-old-tck ) runs twice, can’t find a reason why.
  2. It would be great if the userguide can be updated with the new changes. I was hoping the profiles – platform and web -  be included in the documentation. The tests run in platform mode(non-standalone) for full and web profile are different for old tck. I should be able to create a PR for this soon.
  3. Can we also plan for a tck bundle with EPL (Eclipse Public Licence) and no “jakarta-“ prefix.

I don't know about 1, I'll take a look though. The other things are fine, looking forward to the PR :)

Kind regards,
Arjan Tijms

 

 

 

Thanks & Regards,
Alwin Joseph

 

From: arjan tijms <arjan.tijms@xxxxxxxxx>
Date: Wednesday, 6 July 2022 at 8:13 PM
To: Scott Marlow <smarlow@xxxxxxxxxx>
Cc: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>, Alwin Joseph <alwin.joseph@xxxxxxxxxx>, jaspic developer discussions <jaspic-dev@xxxxxxxxxxx>
Subject: Re: [jakartaee-tck-dev] [External] : Jakarta Authentication TCK 3.0.1 staged 3.0.1-SNAPSHOT

Hi,

 

 

It should be fine now, but let me know if any other issues are found.

 

Kind regards,

Arjan Tijms

 

 

On Wed, Jul 6, 2022 at 4:28 PM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:

Hi,

 

The idea is to just type "mvn clean install" from the root. I'll update staged version to get rid of that 3.0.1-SNAPSHOT. The scripts use mvn to update the versions to the release, but they always miss something.

 

Kind regards,

Arjan Tijms

 

On Wed, Jul 6, 2022 at 3:52 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

I downloaded https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-authentication-tck-3.0.1.zip and searched the contents for `3.0.1-SNAPSHOT`and do see the snapshot reference in authentication-tck-3.0.1/tck/old-tck/build/pom.xml:

"

   <parent>
       <groupId>org.eclipse.ee4j</groupId>
       <artifactId>project</artifactId>
       <version>1.0.6</version>
       <relativePath />
   </parent>

   <groupId>org.eclipse.ee4j.tck.authentication</groupId>
   <artifactId>old-authentication-tck</artifactId>
   <version>3.0.1-SNAPSHOT</version>
   <packaging>pom</packaging>

   <name>Old Jakarta Authentication TCK - build</name>
"

Is the idea that users are building the org.eclipse.ee4j.tck.authentication:old-authentication-tck:3.0.1-SNAPSHOT? 

 

On 7/6/22 6:42 AM, arjan tijms wrote:

 

 

On Wed, Jul 6, 2022 at 8:25 AM Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Hi Arjan,

 

  1. I see the old-tck is not integrated with the main pom as a module to be executed from authentication-tck-3.0.1/tck. Is this expected? Should we be running the old tck tests separately from authentication-tck-3.0.1/tck/old-tck.

 

That's strange, they should run by default via the profile:

 

 

 

  1.  
  2. I was trying to run the old tck tests from authentication-tck-3.0.1/tck/old-tck, using “mvn clean install -Pstaging,glassfish-ci-managed,platform -Dglassfish.version=7.0.0-M6”. I get pom.xml not found, possibly due to version mismatch between 3.0.1-SNAPSHOT and 3.0.1.

 

Does that also happen with the staged version, or only when running from a checkout of the repository?

 

Kind regards,

Arjan Tijms

 

 

 

  1.  

 

Thanks & Regards,
Alwin Joseph

 

From: arjan tijms <arjan.tijms@xxxxxxxxx>
Date: Wednesday, 6 July 2022 at 1:32 AM
To: jaspic developer discussions <jaspic-dev@xxxxxxxxxxx>, jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
Cc: Gurunandan Rao <gurunandan.rao@xxxxxxxxxx>, Alwin Joseph <alwin.joseph@xxxxxxxxxx>, Darran Lofthouse <darran.lofthouse@xxxxxxxxx>
Subject: [External] : Jakarta Authentication TCK 3.0.1 staged

Hi,

 

I just staged the service release of the Jakarta Authentication TCK here: https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-authentication-tck-3.0.1.zip

 

The major thing fixed in the service release is merging the two bundles from the 3.0.0 release into one. A smaller fix is printing the result summary directly in the log of a maven build. Previously the result summary was dependent on parsing the junit xml based file.

 

If the TCK bundle is found to be correct, we can initiate its promotion.

 

I just tested it on GlassFish 7.0 M6, where it passes.

 

Kind regards,

Arjan Tijms



_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top