Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] tckrefactor branch


On Tue, Dec 7, 2021 at 8:12 AM Scott Marlow <smarlow@xxxxxxxxxx> wrote:


On 11/30/21 2:24 PM, Scott Marlow wrote:


On 11/23/21 3:33 AM, Olivier Lamy wrote:
Hi,

I’m looking at working on the servlet module.
Ideally I’d like to have this compiling mvn clean install -pl :servlet
-am  some classes in the common module use classes from the runtime
module.
But this one has been commented on. Any reason?

From what I recall, the common folder contains the current `vehicles` that likely depend on the Java Test Harness
(currently referenced from runtime mostly).  The Java Test Harness references need to be removed I think but we need to replace them with equivalent Arquillian/ShrinkWrap code I think.  I suppose that we could of just deleted all of the references to the Java Test Harness but we didn't do that, in case it helps to see the current (Java Test Harness) usage. 

Perhaps its a good time now to remove the Java Test Harness usage (in common + servlet, other areas) so we can get closer to zero build failures.


Yes definitely!
I will start some work on that for sure
 


The code is using different httpclients.
Do we want to use java.net.http.HttpClient or anything else? (Jetty
client, Apache etc..)

Do you think https://github.com/eclipse-ee4j/jakartaee-tck/issues/736 would be the right issue to discuss httpclients? 


yes definitely a good idea to use some default jdk client.
 



cheers


cheers

Scott



--
Olivier

Back to the top