Re: [jakartaee-tck-dev] What is the best way to replace remaining < EE 8

[<dmitry.kornilov@xxxxxxxxxx>]

Re-posting to the platform mailing list. My summary of the issue:

We've added new schemas for some specifications (JPA, JAXB, JAXWS, etc.) to reflect javax->jakarta namespace change. Scott is asking are we required to update TCK tests to use these schemas? In my opinion it has to be done, but it may require some significant amount of time/resources which may have a negative impact on the release schedule.

See the original discussion here: https://github.com/eclipse-ee4j/jakartaee-tck/issues/385#issuecomment-673159896

Comments?

Thanks,
Dmitry

-----Original Message-----
From: jakartaee-tck-dev-bounces@xxxxxxxxxxx <jakartaee-tck-dev-bounces@xxxxxxxxxxx> On Behalf Of Scott Marlow
Sent: Thursday, 13 August 2020 03:37
To: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
Subject: Re: [jakartaee-tck-dev] What is the best way to replace remaining < EE 8 XSD schemas in the Platform TCK with EE 9 Schemas?



On 8/12/20 9:30 PM, Scott Marlow wrote:
> Technically, as per
> https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee-
> platform/blob/gh-pages/minutes/2020-01-28.md__;!!GqivPVa7Brio!I1amDPWj
> V_HabwnliZNSbuqlYb-S7C02jw_5owP11iWGtpIqnAGq0eoMCOaVxVpn_1m-$ , we also can use EE 8 schemas as well, but if we are updating a TCK test, IMO, we should update to reference an EE 9 schema.

Official minutes link is
https://urldefense.com/v3/__https://eclipse-ee4j.github.io/jakartaee-platform/minutes/2020-01-28.html__;!!GqivPVa7Brio!I1amDPWjV_HabwnliZNSbuqlYb-S7C02jw_5owP11iWGtpIqnAGq0eoMCOaVxdIbensm$ 

> 
> On 8/12/20 8:37 PM, Scott Marlow wrote:
>> Hi,
>>
>> Thanks Lukas for speaking up about the "< EE 8" schema references 
>> that are still in the Platform TCK tests [1]!
>>
>> For the previous schema updates made for issue 266 [2], we did a 
>> global search/replace of the various XSD/namespace references and 
>> then did a separate update to correct some schema versions that were 
>> wrong.  This was a clumsy way to make the changes.
>>
>> For example, with the Silversearcher tool, we did a find of 
>> references to web-facesconfig_1.2.xsd and used sed to actually to the 
>> search/replace (ag is faster at determining the files to update).
>>
>> ag --ignore .git -l
>> http://java.sun.com/xml/ns/javaee/web-facesconfig_1_2.xsd| xargs sed 
>> -i 
>> 's/http:%5C/%5C/java.sun.com%5C/xml%5C/ns%5C/javaee%5C/web-facesconfig_1_2.xsd/https:%5C/%5C/jakarta.ee%5C/xml%5C/ns%5C/jakartaee%5C/web-facesconfig_3_0.xsd/g'
>>
>>
>> At this point, I don't think it is important to use SilverSearcher as 
>> much as it is to do the search/replace with the fewest possible 
>> steps/tools and also have some confidence that the update is likely 
>> correct (we will have reviewers check the pull requests involved of 
>> course).
>>
>> One risk of these schema changes is that we may see more failures if 
>> the EE 9 schemas are not used by all components that we are using for 
>> EE 9 testing.
>>
>> Any suggestions on the best way to update the remaining Platform TCK 
>> tests to use EE 9 schemas for [2][1]?
>>
>> Thanks,
>> Scott
>>
>> [1] 
>> https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee
>> -tck/issues/385__;!!GqivPVa7Brio!I1amDPWjV_HabwnliZNSbuqlYb-S7C02jw_5
>> owP11iWGtpIqnAGq0eoMCOaVxfQzlBX6$ [2] 
>> https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee
>> -tck/issues/266__;!!GqivPVa7Brio!I1amDPWjV_HabwnliZNSbuqlYb-S7C02jw_5
>> owP11iWGtpIqnAGq0eoMCOaVxaTP5Q9F$

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!I1amDPWjV_HabwnliZNSbuqlYb-S7C02jw_5owP11iWGtpIqnAGq0eoMCOaVxfHBVr7r$