Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Pkg renames for websocket tck


On Mon, Apr 13, 2020 at 8:13 AM Frederick W Rowe <frowe@xxxxxxxxxx> wrote:
I submitted PR https://github.com/eclipse-ee4j/jakartaee-tck/pull/197 to update websocket tck.  Because there were path elements like websocket/ee/javax, I renamed those paths which resulted in a lot of rename only changes. 

Question for anyone following, are there any existing path elements that use javax, that shouldn't also be renamed.  

From a consistency point of view, IMO, we can also change the javax paths to jakarta but the only actual problems that come to mind, are with service files (e.g. tests/jpa/common/pluggability/altprovider/METAINF/services/javax.persistence.spi.PersistenceProvider updated to use jakarta).

So for consistency, I'm a +1!  Any other reasons why we have to change these?

I used the glassfish copyright plugin to update anything that was modified or modified and renamed (M or RM in porcelain output), but not if just some element of the path to a file was renamed (R output).

Thanks for handling these changes, your help is greatly appreciated! :)

Regards,
Scott



Regards,

Fred Rowe

WebSphere Architect for JCA/JDBC connectivity and WAS for IBM i
Senior Software Engineer
IBM Cloud
frowe@xxxxxxxxxx

-----jakartaee-tck-dev-bounces@xxxxxxxxxxx wrote: -----
To: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
From: Scott Marlow
Sent by: jakartaee-tck-dev-bounces@xxxxxxxxxxx
Date: 04/08/2020 07:39PM
Subject: [EXTERNAL] Re: [jakartaee-tck-dev] Next steps for updating the jakartaee-tck repo...



On Fri, Apr 3, 2020 at 2:27 PM Frederick W Rowe <frowe@xxxxxxxxxx> wrote:
I had volunteered to update the concurrency TCK and was about to create a PR, but if you're going to do a global replace, I'll just dump my branch and let you do it.  Applying the same replace rules across all projects is probably a good idea...

Fred,

Your change is merged, thank you very much for making the change!

We still have around 10288 files with javax.* references in the TCK, so if you can help with other TCKs or global TCK changes, that is very much appreciated!  :)

Scott
 


Regards,

Fred Rowe

WebSphere Architect for JCA/JDBC connectivity and WAS for IBM i
Senior Software Engineer
IBM Cloud
frowe@xxxxxxxxxx

-----jakartaee-tck-dev-bounces@xxxxxxxxxxx wrote: -----
To: jakartaee-tck-dev@xxxxxxxxxxx
From: Scott Marlow
Sent by: jakartaee-tck-dev-bounces@xxxxxxxxxxx
Date: 04/03/2020 09:24AM
Subject: [EXTERNAL] [jakartaee-tck-dev] Next steps for updating the jakartaee-tck repo...

Hi,

I just wanted to take a moment to discuss who is doing what, for the next few steps to update the TCK source for EE9.  We had a few pull requests recently that duplicated effort, which can be painful for one of the authors to update, as they tend to be lengthy.

I would like to do the following search + replace to update most of the remaining javax namespace class references, each one as a separate pull request:

ag --ignore .git  -l javax.| xargs sed -i 's/javax\.enterprise\./jakarta\.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.faces\./jakarta\.faces\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.inject\./jakarta\.inject\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.interceptor\./jakarta\.interceptor\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.jms\./jakarta\.jms\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.json\./jakarta\.json\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.mail\./jakarta\.mail\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.management.j2ee\./jakarta\.management.j2ee\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.persistence\./jakarta\.persistence\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.resource\./jakarta\.resource\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.auth\./jakarta\.security.auth\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.enterprise\./jakarta\.security.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.jacc\./jakarta\.security.jacc\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.servlet\./jakarta\.servlet\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.validation\./jakarta\.validation\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.websocket\./jakarta\.websocket\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.ws\.rs\./jakarta\.ws\.rs\./g'

The "ag" command is from http://geoff.greer.fm/ag.

Will also try to use the GlassFish Copyright plugin to update the Copyright date in the modified files:

repo=~/.m2/repository/org/glassfish/copyright/glassfish-copyright-maven-plugin
v=`ls $repo | grep '^[1-9]' | tail -1`
for i in `git status  --porcelain --untracked-files=no | cut -d' ' -f3`; do java -cp $repo/$v/glassfish-copyright-maven-plugin-$v.jar org.glassfish.copyright.Copyright -r -c $i; done

Is anyone else planning on updating any of the above packages?  Perhaps we could split them up.

Scott




_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top