Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Next steps for updating the jakartaee-tck repo...

Hi Scott,

I'll start with javax.validation and make the changes and raise a PR. Also once I am done with changes with javax.validation, I can pick other tck as well.

On 4/8/2020 6:13 PM, Alwin Joseph wrote:

Thanks Scott.

1. It would be better if these changes can ignore the directory src/com/sun/ts/tests/signaturetest/signature-repository for now.

2. I will start with javax.inject & javax.interceptor; make the changes in two separate PRs.

Thanks & Regards,
Alwin Joseph

On 03/04/20 9:51 PM, Kevin Sutter wrote:
Thanks, Scott!

>  ag --ignore .git  -l javax.| xargs sed -i 's/javax\.management.j2ee\./jakarta\.management.j2ee\./g'

This one should not be required since J2EE Management is pruned from Jakarta EE 9.  So, we should just remove this one from the package.  Other than that, it looks like a great start to this effort.  Thanks!

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn: https://www.linkedin.com/in/kevinwsutter



From:        Scott Marlow <smarlow@xxxxxxxxxx>
To:        jakartaee-tck-dev@xxxxxxxxxxx
Date:        04/03/2020 10:24
Subject:        [EXTERNAL] [jakartaee-tck-dev] Next steps for updating the jakartaee-tck        repo...
Sent by:        jakartaee-tck-dev-bounces@xxxxxxxxxxx



Hi,

I just wanted to take a moment to discuss who is doing what, for the next few steps to update the TCK source for EE9.  We had a few pull requests recently that duplicated effort, which can be painful for one of the authors to update, as they tend to be lengthy.

I would like to do the following search + replace to update most of the remaining javax namespace class references, each one as a separate pull request:

ag --ignore .git  -l javax.| xargs sed -i 's/javax\.enterprise\./jakarta\.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.faces\./jakarta\.faces\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.inject\./jakarta\.inject\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.interceptor\./jakarta\.interceptor\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.jms\./jakarta\.jms\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.json\./jakarta\.json\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.mail\./jakarta\.mail\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.management.j2ee\./jakarta\.management.j2ee\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.persistence\./jakarta\.persistence\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.resource\./jakarta\.resource\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.auth\./jakarta\.security.auth\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.enterprise\./jakarta\.security.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.jacc\./jakarta\.security.jacc\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.servlet\./jakarta\.servlet\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.validation\./jakarta\.validation\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.websocket\./jakarta\.websocket\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.ws\.rs\./jakarta\.ws\.rs\./g'

The "ag" command is from http://geoff.greer.fm/ag.

Will also try to use the GlassFish Copyright plugin to update the Copyright date in the modified files:

repo=~/.m2/repository/org/glassfish/copyright/glassfish-copyright-maven-plugin
v=`ls $repo | grep '^[1-9]' | tail -1`
for i in `git status  --porcelain --untracked-files=no | cut -d' ' -f3`; do java -cp $repo/$v/glassfish-copyright-maven-plugin-$v.jar org.glassfish.copyright.Copyright -r -c $i; done

Is anyone else planning on updating any of the above packages?  Perhaps we could split them up.

Scott



_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev





_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev



_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!NH9z3kBkGR9iG0DKlnQOXV3mZF_8U1Acze9P02s_U00FamgYSEHQkjzVESIF5XMZIKY$
--
Thanks & Regards

Oracle
Rohit Kumar Jain, Senior Member Of Technical Staff
Mobile: 9036132401
Oracle WLS

India, Oracle India Pvt. Ltd., 560076 Bangalore

Back to the top