Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Next steps for updating the jakartaee-tck repo...



On Fri, Apr 3, 2020 at 2:27 PM Frederick W Rowe <frowe@xxxxxxxxxx> wrote:
I had volunteered to update the concurrency TCK and was about to create a PR, but if you're going to do a global replace, I'll just dump my branch and let you do it.  Applying the same replace rules across all projects is probably a good idea...

Oh right, sorry, you mentioned that before.  I will do the javax.resource change, which doesn't seem to impact the concurrency TCK, so please do that one.  Your approach of handling that specific TCK is very much appreciated and also a good idea.

It seems that each global replace, runs into different issues, especially around the Copyright dates, for example the glassfish-copyright-maven-plugin just added a new "Copyright (c) 2020 Oracle and/or its affiliates" in lib/schemas/connector_1_5.xsd, in addition to the existing "Copyright 2003-2007 Sun Microsystems" that is not supposed to be altered or removed.  Hmm...

Scott



Regards,

Fred Rowe

WebSphere Architect for JCA/JDBC connectivity and WAS for IBM i
Senior Software Engineer
IBM Cloud
frowe@xxxxxxxxxx


-----jakartaee-tck-dev-bounces@xxxxxxxxxxx wrote: -----
To: jakartaee-tck-dev@xxxxxxxxxxx
From: Scott Marlow
Sent by: jakartaee-tck-dev-bounces@xxxxxxxxxxx
Date: 04/03/2020 09:24AM
Subject: [EXTERNAL] [jakartaee-tck-dev] Next steps for updating the jakartaee-tck repo...

Hi,

I just wanted to take a moment to discuss who is doing what, for the next few steps to update the TCK source for EE9.  We had a few pull requests recently that duplicated effort, which can be painful for one of the authors to update, as they tend to be lengthy.

I would like to do the following search + replace to update most of the remaining javax namespace class references, each one as a separate pull request:

ag --ignore .git  -l javax.| xargs sed -i 's/javax\.enterprise\./jakarta\.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.faces\./jakarta\.faces\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.inject\./jakarta\.inject\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.interceptor\./jakarta\.interceptor\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.jms\./jakarta\.jms\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.json\./jakarta\.json\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.mail\./jakarta\.mail\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.management.j2ee\./jakarta\.management.j2ee\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.persistence\./jakarta\.persistence\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.resource\./jakarta\.resource\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.auth\./jakarta\.security.auth\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.enterprise\./jakarta\.security.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security.jacc\./jakarta\.security.jacc\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.servlet\./jakarta\.servlet\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.validation\./jakarta\.validation\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.websocket\./jakarta\.websocket\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.ws\.rs\./jakarta\.ws\.rs\./g'

The "ag" command is from http://geoff.greer.fm/ag.

Will also try to use the GlassFish Copyright plugin to update the Copyright date in the modified files:

repo=~/.m2/repository/org/glassfish/copyright/glassfish-copyright-maven-plugin
v=`ls $repo | grep '^[1-9]' | tail -1`
for i in `git status  --porcelain --untracked-files=no | cut -d' ' -f3`; do java -cp $repo/$v/glassfish-copyright-maven-plugin-$v.jar org.glassfish.copyright.Copyright -r -c $i; done

Is anyone else planning on updating any of the above packages?  Perhaps we could split them up.

Scott




_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top