| Re: [jakartaee-spec-project-leads] GitHub bots failing ECA validation |
_______________________________________________Yes you need another committer to approve.
From: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx <jakartaee-spec-project-leads-bounces@xxxxxxxxxxx> On Behalf Of Tom Jenkinson
Sent: 11 June 2020 15:08
To: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>
Subject: Re: [jakartaee-spec-project-leads] GitHub bots failing ECA validation
Hmm, perhaps that will be so but I think I need a JTA committer to review https://github.com/eclipse-ee4j/jta-api/pull/106 to be sure though. I will ask on the jta-dev mailing list for a review from a committer.
Thanks,
Tom
On Thu, 11 Jun 2020 at 14:59, Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:
You should just have the option to merge the PR even though the validation check has failed?
From: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx <jakartaee-spec-project-leads-bounces@xxxxxxxxxxx> On Behalf Of Tom Jenkinson
Sent: 11 June 2020 14:48
To: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>
Cc: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx
Subject: Re: [jakartaee-spec-project-leads] GitHub bots failing ECA validation
I tried to recreate the pull request to see if I could retrigger validation (although I don't think that would make any difference) but that seems to have got something out of sync between github and eclipse validation and so if you click through to the validation in the checks section now it seems to be for a validation that is no longer available (maybe it was the one for https://github.com/eclipse-ee4j/jta-api/pull/91). That being said, I don't see a way to override - the branch is protected so that could be it.
On Thu, 11 Jun 2020 at 14:16, Kevin Sutter <sutter@xxxxxxxxxx> wrote:
+1
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
To: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>, Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>
Date: 06/11/2020 05:05
Subject: [EXTERNAL] Re: [jakartaee-spec-project-leads] GitHub bots failing ECA validation
Sent by: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx
I think you can just override and merge as a committer as there isn’t an IP issue as it is a project bot.
From:jakartaee-spec-project-leads-bounces@xxxxxxxxxxx <jakartaee-spec-project-leads-bounces@xxxxxxxxxxx> On Behalf Of Tom Jenkinson
Sent: 11 June 2020 10:42
To: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>; Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>
Subject: [jakartaee-spec-project-leads] GitHub bots failing ECA validation
Hi,
Is there any update on when and how pull requests which contain commits from known bots (such as jta-bot) will be able to be included in branches which are checked for ECA? The latest I see on https://bugs.eclipse.org/bugs/show_bug.cgi?id=552628indicates to me that it is not possible yet.
Commits from these bots will go into unprotected branches and tags (presumably because they are unprotected), but can't get on a protected branch - failing a validation check for the PR. For now, that means that a release branch cannot be synced back into master.
Perhaps we might need to change https://wiki.eclipse.org/JakartaEE_New_Infra_Release_Jobsuch that it doesn't use a bot to create new commits and that becomes part of the role of the person that releases a version so these branches can be synced back?
Thanks,
Tom_______________________________________________
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
_______________________________________________
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads_______________________________________________
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads