Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-spec-project-leads] Consistent checkboxes for jakartaee/specifications PRs & review notes everyone should know

The GlassFish web site is more complicated than that.  Instructions here.

Tom Jenkinson wrote on 8/1/19 2:45 PM:


On Thu, 1 Aug 2019 at 22:11, Bill Shannon <bill.shannon@xxxxxxxxxx> wrote:
Tom Jenkinson wrote on 8/1/19 1:53 AM:


# CERTIFICATION REQUEST

The URL of the compatibility certification request issue must be something like these:

 - https://github.com/eclipse-ee4j/mail-spec/issues/1
 - https://github.com/eclipse-ee4j/batch-tck/issues/1
 - https://github.com/eclipse-ee4j/injection-spec/issues/3

You need to use the exact TCK linked in PR, not a snapshot or "latest.zip"

The TCK results must be hosted by the Compatible Implementation, not the Specification Project.  Links to the Specification Project's CI (continuous integration, aka Jenkins job) are not valid.

Please can you confirm, the certification request can be on the API project but the TCK results must be hosted on the compatible implementation?

For example:
https://github.com/eclipse-ee4j/jta-api/issues/50 (certification request on API project)

That's correct.

The certification request must be on the project that contains the specification.  Often that is the API project.

The TCK results must be hosted by the compatible implementation.

(Note that there's a proposal to host the GlassFish-related TCK results on the GlassFish web site, not in the repository as per your pull request above.  Check with Steve Millidge.)

I asked on glassfish-dev and I think I have raised the PR in the right place as per https://www.eclipse.org/lists/glassfish-dev/msg00071.html (gh-pages is the branch for Glassfish website I thought/expect)


Back to the top