Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-platform-dev] [jakarta.ee-spec] Dependency Analysis with jQA - Cyclic Dependency in all Platform Profiles!

Hi Tom,

I agree - Transactions has CDI as valid dependency (right direction, higher level to lower), the core problem is the required dependency of CDI to an already outdated version of Transactions - for documentation reasons only.

But to solve the issue, a new release of Transactions is necessary - it it must be a major one, because of breaking changes for Transactions consumers: CDI 3.0 to CDI (Lite) 4.0 and the drop of support for Java SE Versions below 11 (!).
There are a few things to clean up regarding the last reason, like the following:

...

And you can do this final major release of Transactions first, if CDI has fixed its issue and you can reference that version because of the cycle.

Best,
Jan

Am 13.05.22 um 18:47 schrieb Tom Jenkinson:
Hi Jan,

Given that Jakarta Transactions has a compilation dependency on CDI (for instance: https://github.com/jakartaee/transactions/blob/master/api/src/main/java/jakarta/transaction/Transactional.java#L19) I don't expect the cycle is likely broken by (at least a straightforward) removal of the CDI dependency from Transactions, but I welcome input if someone sees options there.

Thanks,
Tom

On Fri, 13 May 2022 at 11:58, Jan Westerkamp <jan.westerkamp@xxxxxxx> wrote:
Hello together,

I updated the jQA repo and let fixed the issue with an outdated index at
Sonatype for the staging repo (again) - now we have new results for the
upcoming Jakarta EE 10.0.0 release!

I uploaded the report results in a zip file to
https://github.com/eclipse-ee4j/jakartaee-api/issues/125.

The good news: We are making progress solving issues with dependencies!

The bad news: We have a cyclic dependency in all the Platform Profiles
(Core, Web and "Full"/Platform):

CDI has a required dependency to Jakarta Transactions, which in turn has
has required dependency to an older CDI version!
I think, besides Jakarta Transactions referencing an old version of CDI,
the last must not have a dependency to Transactions at all (or at least
not a required one using: <optional>true</optional> <!-- value will be
true or false only -->).

Regarding the comment in CDI, this reference is only used in Javadoc
references:
             <!-- Only for javadoc references -->
             <dependency>
                 <groupId>jakarta.transaction</groupId>
<artifactId>jakarta.transaction-api</artifactId>
<version>${transaction.api.version}</version>
             </dependency>

There are notes in the POM at property level like that too:
         <!-- These are only used in javadoc links -->
         <ejb.api.version>4.0.0</ejb.api.version>
<transaction.api.version>2.0.0</transaction.api.version>

But Transactions will need a updated version to be released and part of
the referencing spec configurations too!

It would be even better to get rid of that cyclic dependency at all, if
possible to prevent future issues like that.

You can see this issue at best in the simpler Core Profile graph
(jakarta.jakartaee-core-api/plantuml/jakarta-ee-dependencies_PlatformDependencyDiagram.svg
and the version list
(jakarta.jakartaee-core-api/plantuml/jakarta-ee-dependencies_PlatformDependencyVersionsByArtifact.csv)
in the zip file mentioned above. The Core Profile should not depend on
Transactions (and my be others required by CDI directly), but the
dependency problem with resulting versioning issues can be seen in all
Profiles, sometimes even worse regarding the use of API versions.

How do we proceed with that issue? Creating on in the relevant spec
projects (CDI, Transactions and Platform) and discuss this first here in
the mailing list or in the Jakarta Platform call (that might cause delay)?

Best,

Jan

PS: This might not be the only finding in the jQA analysis, but my first
severe one - it might be helpful to spend some additional time into it.

_______________________________________________
jakarta.ee-spec mailing list
jakarta.ee-spec@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakarta.ee-spec

_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev



Back to the top